Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272863: Replace usages of Collections.sort with List.sort call in public java modules #5229

Conversation

@turbanoff
Copy link
Member

@turbanoff turbanoff commented Aug 23, 2021

Collections.sort is just a wrapper, so it is better to use an instance method directly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272863: Replace usages of Collections.sort with List.sort call in public java modules

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5229/head:pull/5229
$ git checkout pull/5229

Update a local copy of the PR:
$ git checkout pull/5229
$ git pull https://git.openjdk.java.net/jdk pull/5229/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5229

View PR using the GUI difftool:
$ git pr show -t 5229

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5229.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 23, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

@turbanoff The following labels will be automatically applied to this pull request:

  • 2d
  • awt
  • core-libs
  • i18n
  • net
  • security
  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mrserb
mrserb approved these changes Aug 23, 2021
Copy link
Member

@mrserb mrserb left a comment

The changes in the src/java.desktop/ looks fine.

@mrserb
Copy link
Member

@mrserb mrserb commented Aug 23, 2021

@turbanoff turbanoff changed the title [PATCH] Replace usages of Collections.sort with List.sort call in public java modules 8272863: Replace usages of Collections.sort with List.sort call in public java modules Aug 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272863: Replace usages of Collections.sort with List.sort call in public java modules

Reviewed-by: serb, dfuchs, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • 2ef6871: 8272447: Remove 'native' ranked Mutex
  • 63e062f: 8236176: Parallel GC SplitInfo comment should be updated for shadow regions
  • c5a2712: 8272850: Drop zapping values in the Zap* option descriptions
  • 1e3e333: 8272884: Make VoidClosure::do_void pure virtual
  • 0f428ca: 8272570: C2: crash in PhaseCFG::global_code_motion
  • b17b821: 8272639: jpackaged applications using microphone on mac
  • 0e7288f: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions
  • 6ace805: 8272856: DoubleFlagWithIntegerValue uses G1GC-only flag
  • c547ead: 8272916: Copyright year was modified unintentionally in jlink.properties and ImagePluginStack.java
  • aaedac6: 8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/709b5910c35ad081b2367435cbc689414098b87a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @dfuch, @naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 24, 2021

Webrevs

dfuch
dfuch approved these changes Aug 24, 2021
Copy link
Member

@dfuch dfuch left a comment

java/net and sun/net changes LGTM

naotoj
naotoj approved these changes Aug 24, 2021
Copy link
Member

@naotoj naotoj left a comment

java.time changes look good.

@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Aug 24, 2021

Is there any reason to not touch them along with this fix?

Update them too.

@turbanoff turbanoff force-pushed the use_list.sort_instead_of_collections.sort_java_modules branch from d6dfc8b to e31936a Aug 25, 2021
@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Aug 25, 2021

/integrate

@openjdk openjdk bot added the sponsor label Aug 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 25, 2021

@turbanoff
Your change (at version e31936a) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

@mrserb mrserb commented Aug 26, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2021

Going to push as commit d732c30.
Since your change was applied there have been 37 commits pushed to the master branch:

  • fe7d708: 8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong
  • 845e1ce: 8272983: G1 Add marking details to eager reclaim logging
  • c420530: 8272481: [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java fails
  • e43a907: 8271315: Redo: Nimbus JTree renderer properties persist across L&F changes
  • 11c9fd8: 8272975: ParallelGC: add documentation to heap memory layout
  • b94fd32: 8272859: Javadoc external links should only have feature version number in URL
  • 9166ba3: 8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop
  • 49b2789: 8262751: RenderPipelineState assertion error in J2DDemo
  • a3308af: 8272836: Limit run time for java/lang/invoke/LFCaching tests
  • c4c76e2: 8272811: Document the effects of building with _GNU_SOURCE in os_posix.hpp
  • ... and 27 more: https://git.openjdk.java.net/jdk/compare/709b5910c35ad081b2367435cbc689414098b87a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 26, 2021
@openjdk openjdk bot added the integrated label Aug 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2021

@mrserb @turbanoff Pushed as commit d732c30.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the use_list.sort_instead_of_collections.sort_java_modules branch Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment