New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8272878: JEP 381 cleanup: Remove unused Solaris code in sun.font.TrueTypeGlyphMapper #5232
Conversation
|
It looks like the commit message must reference an issue, so I've submitted an issue via https://bugreport.java.com/. The internal review ID is 9071267. I can update the commit message once the issue has been reviewed and assigned an actual issue number. |
/issue JDK-8272879 |
/issue JDK-8272879 |
@gredler The issue |
/issue JDK-8272878 |
@gredler The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated. |
@gredler This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 119 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @jayathirthrao) but any other Committer may sponsor as well.
|
/integrate |
As per JEP 381, comments pointing to Solaris also need to be looked into or purged. There seem to be around 96 mention of Solaris still in java_desktop module...Can it be looked into in this PR? |
I had initially wanted to keep this PR focused on a small, self-contained, fairly obvious change, since this is my first contribution to the project -- but I'm open to expanding the scope if I can get some direction. It can be argued that many of the comments which mention Solaris still provide useful background information, e.g.:
There are some other comments that could more obviously be fixed without issues:
|
I'm with Daniel on this one. I'd have to think about how to update those comments. |
I do not have any objection to this looking into comments in future and not in this PR. |
I think LittleCMS explicitly supports Solaris, so I doubt a patch removing Solaris support would be accepted upstream. It does look like XScrollbarPeer should be cleaned up, but should it be done as part of this PR? Let me know either way. I'm also looking for a sponsor for this PR, would either @prrace or @prsadhuk have some time to spare? Thanks! |
Completely out of scope by a country mile to get anywhere near the LCMS support for Solaris. I will sponsor this if it is ready. The submitter needs to type /integrate and only after that does /sponsor do anything. |
/integrate |
@prsadhuk I will raise a separate PR in the coming days to address the XScrollbarPeer cleanup. |
/sponsor |
Going to push as commit 70ed6c5.
Your commit was automatically rebased without conflicts. |
@jayathirthrao @gredler Pushed as commit 70ed6c5. |
During the recent JEP 381 removal of Solaris code, a few Solaris-specific constants and private methods were left behind in sun.font.TrueTypeGlyphMapper. This PR removes these unused odds and ends.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5232/head:pull/5232
$ git checkout pull/5232
Update a local copy of the PR:
$ git checkout pull/5232
$ git pull https://git.openjdk.java.net/jdk pull/5232/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5232
View PR using the GUI difftool:
$ git pr show -t 5232
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5232.diff