Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272856: DoubleFlagWithIntegerValue uses G1GC-only flag #5233

Closed
wants to merge 1 commit into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Aug 23, 2021

Hi all,

could you please review the patch which replaces the flag used by DoubleFlagWithIntegerValue to SweeperThreshold?

from JBS:

runtime/CommandLine/DoubleFlagWithIntegerValue.java test uses G1ConcMarkStepDurationMillis flag which is available only on the builds w/ G1 GC, hence this test might fail on the builds where G1 is disabled.
instead of adding @requires to exclude the test from running on builds w/o G1, the test can be updated to use the flag that is available in all builds.

testing: runtime/CommandLine/DoubleFlagWithIntegerValue.java on {linux,windows,macosx}-x64

Thanks,
-- Igor


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272856: DoubleFlagWithIntegerValue uses G1GC-only flag

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5233/head:pull/5233
$ git checkout pull/5233

Update a local copy of the PR:
$ git checkout pull/5233
$ git pull https://git.openjdk.java.net/jdk pull/5233/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5233

View PR using the GUI difftool:
$ git pr show -t 5233

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5233.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 23, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8272856 8272856: DoubleFlagWithIntegerValue uses G1GC-only flag Aug 23, 2021
@openjdk openjdk bot added the rfr label Aug 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

@iignatev The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Aug 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 23, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

LGTM.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272856: DoubleFlagWithIntegerValue uses G1GC-only flag

Reviewed-by: dholmes, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

  • 22ef4f0: 5015261: NPE may be thrown if JDesktopIcon is set to null on a JInternalFrame
  • 9bc0232: 8269223: -Xcheck:jni WARNINGs working with fonts on Linux
  • 2ff4c01: 8271600: C2: CheckCastPP which should closely follow Allocate is sunk of a loop
  • ad92033: 8272736: [JVMCI] Add API for reading and writing JVMCI thread locals
  • 709b591: 8272553: several hotspot runtime/CommandLine tests don't check exit code
  • 1884072: 8265253: javac -Xdoclint:all gives "no comment" warning for code that can't be commented
  • 594e516: 8272778: Consolidate is_instance and is_instance_inlined in java_lang_String
  • d542745: 8267894: Skip work for empty regions in G1 Full GC
  • 741f58c: 8272417: ZGC: fastdebug build crashes when printing ClassLoaderData
  • b7f75c0: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h
  • ... and 21 more: https://git.openjdk.java.net/jdk/compare/03b5e99d998e037f84e9e2395b49321979c0acd8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 24, 2021
Copy link

@kimbarrett kimbarrett left a comment

Looks good.

@iignatev
Copy link
Member Author

@iignatev iignatev commented Aug 24, 2021

Kim and David, thank you.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

Going to push as commit 6ace805.
Since your change was applied there have been 43 commits pushed to the master branch:

  • c547ead: 8272916: Copyright year was modified unintentionally in jlink.properties and ImagePluginStack.java
  • aaedac6: 8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted
  • d34f17c: 8270195: Add missing links between methods of JavaFX properties
  • f608e81: 8264322: Generate CDS archive when creating custom JDK image
  • f681d65: 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed
  • 6e0328f: 8272725: G1: add documentation on needs_remset_update_t vs bool
  • 2309b7d: 8253178: Replace LinkedList Impl in net.http.FilterFactory
  • 94f5e44: 8271258: @param with non-ascii variable names produces incorrect results
  • 7454306: 8272526: Cleanup ThreadStateTransition class
  • 0597cde: 8221360: Eliminate Shared_DirtyCardQ_lock
  • ... and 33 more: https://git.openjdk.java.net/jdk/compare/03b5e99d998e037f84e9e2395b49321979c0acd8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

@iignatev Pushed as commit 6ace805.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@iignatev iignatev deleted the 8272856 branch Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
3 participants