Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272884: Make VoidClosure::do_void pure virtual #5237

Closed
wants to merge 1 commit into from

Conversation

@albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Aug 24, 2021

Simple change of making VoidClosure::do_void pure virtual.

Test: build


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5237/head:pull/5237
$ git checkout pull/5237

Update a local copy of the PR:
$ git checkout pull/5237
$ git pull https://git.openjdk.java.net/jdk pull/5237/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5237

View PR using the GUI difftool:
$ git pr show -t 5237

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5237.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 24, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Aug 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 24, 2021

Webrevs

Loading

Copy link

@kimbarrett kimbarrett left a comment

Looks good in principle.

But it seems like this needs more testing than just a successful build, to
account for the "breaks in mysterious ways" comment. That comment and pure
virtual avoidance goes back to before mercurial, so might no longer be
relevant (ancient compiler bugs? other problems?). But I don't think just a
successful build tells us that. Though I admit I don't have any theories about
what could go wrong, or even expectations that something will. So I'm
conditionally approving, assuming it passes additional testing, like run a
couple of tiers in our CI.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272884: Make VoidClosure::do_void pure virtual

Reviewed-by: kbarrett, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • 0f428ca: 8272570: C2: crash in PhaseCFG::global_code_motion
  • b17b821: 8272639: jpackaged applications using microphone on mac
  • 0e7288f: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions
  • 6ace805: 8272856: DoubleFlagWithIntegerValue uses G1GC-only flag
  • c547ead: 8272916: Copyright year was modified unintentionally in jlink.properties and ImagePluginStack.java
  • aaedac6: 8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted
  • d34f17c: 8270195: Add missing links between methods of JavaFX properties
  • f608e81: 8264322: Generate CDS archive when creating custom JDK image
  • f681d65: 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed
  • 6e0328f: 8272725: G1: add documentation on needs_remset_update_t vs bool
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/594e5161b48382d61509b4969bc8f52c3c076452...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Aug 24, 2021
@albertnetymk
Copy link
Member Author

@albertnetymk albertnetymk commented Aug 24, 2021

More test: tier1-3 pass.

Loading

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Aug 25, 2021

FYI it started as pure virtual in July 2000 but then in May 2001 was changed with the comment "Workaround for a compiler bug" - so I think you are safe. :)

Loading

@albertnetymk
Copy link
Member Author

@albertnetymk albertnetymk commented Aug 25, 2021

Thank you for the review.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 25, 2021

Going to push as commit 1e3e333.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 0f428ca: 8272570: C2: crash in PhaseCFG::global_code_motion
  • b17b821: 8272639: jpackaged applications using microphone on mac
  • 0e7288f: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions
  • 6ace805: 8272856: DoubleFlagWithIntegerValue uses G1GC-only flag
  • c547ead: 8272916: Copyright year was modified unintentionally in jlink.properties and ImagePluginStack.java
  • aaedac6: 8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted
  • d34f17c: 8270195: Add missing links between methods of JavaFX properties
  • f608e81: 8264322: Generate CDS archive when creating custom JDK image
  • f681d65: 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed
  • 6e0328f: 8272725: G1: add documentation on needs_remset_update_t vs bool
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/594e5161b48382d61509b4969bc8f52c3c076452...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Aug 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 25, 2021

@albertnetymk Pushed as commit 1e3e333.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@albertnetymk albertnetymk deleted the voidclosure branch Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants