Skip to content

8272975: ParallelGC: add documentation to heap memory layout #5247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Aug 25, 2021

Simple change of adding some documentation.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272975: ParallelGC: add documentation to heap memory layout

Reviewers

Contributors

  • Thomas Schatzl <tschatzl@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5247/head:pull/5247
$ git checkout pull/5247

Update a local copy of the PR:
$ git checkout pull/5247
$ git pull https://git.openjdk.java.net/jdk pull/5247/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5247

View PR using the GUI difftool:
$ git pr show -t 5247

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5247.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 25, 2021
@openjdk
Copy link

openjdk bot commented Aug 25, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Aug 25, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2021

Webrevs

@albertnetymk
Copy link
Member Author

/contributor add tschatzl

@openjdk
Copy link

openjdk bot commented Aug 25, 2021

@albertnetymk
Contributor Thomas Schatzl <tschatzl@openjdk.org> successfully added.

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm (and trivial if it matters, but please let somebody else have a look at it too).

@openjdk
Copy link

openjdk bot commented Aug 25, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272975: ParallelGC: add documentation to heap memory layout

Co-authored-by: Thomas Schatzl <tschatzl@openjdk.org>
Reviewed-by: tschatzl, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 25, 2021
Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 26, 2021

Going to push as commit 11c9fd8.
Since your change was applied there have been 19 commits pushed to the master branch:

  • b94fd32: 8272859: Javadoc external links should only have feature version number in URL
  • 9166ba3: 8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop
  • 49b2789: 8262751: RenderPipelineState assertion error in J2DDemo
  • a3308af: 8272836: Limit run time for java/lang/invoke/LFCaching tests
  • c4c76e2: 8272811: Document the effects of building with _GNU_SOURCE in os_posix.hpp
  • 673ce7e: 8272873: C2: Inlining should not depend on absolute call site counts
  • 7212561: 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah
  • e36cbd8: 8242847: G1 should not clear mark bitmaps with no marks
  • 2ef6871: 8272447: Remove 'native' ranked Mutex
  • 63e062f: 8236176: Parallel GC SplitInfo comment should be updated for shadow regions
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/f608e81ad8309a001b8a92563a93b8adee1ce2b8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 26, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 26, 2021
@openjdk
Copy link

openjdk bot commented Aug 26, 2021

@albertnetymk Pushed as commit 11c9fd8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the heap-doc branch August 26, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants