Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop #5248

Closed
wants to merge 1 commit into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Aug 25, 2021

Fixed the Embedded * not allowed compile command error and increased number of iterations to reliably trigger C2 compilation.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5248/head:pull/5248
$ git checkout pull/5248

Update a local copy of the PR:
$ git checkout pull/5248
$ git pull https://git.openjdk.java.net/jdk pull/5248/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5248

View PR using the GUI difftool:
$ git pr show -t 5248

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5248.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 25, 2021
@openjdk
Copy link

openjdk bot commented Aug 25, 2021

@TobiHartmann The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Aug 25, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2021

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk
Copy link

openjdk bot commented Aug 25, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop

Reviewed-by: chagedorn, jiefu, neliasso

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 49b2789: 8262751: RenderPipelineState assertion error in J2DDemo
  • a3308af: 8272836: Limit run time for java/lang/invoke/LFCaching tests
  • c4c76e2: 8272811: Document the effects of building with _GNU_SOURCE in os_posix.hpp
  • 673ce7e: 8272873: C2: Inlining should not depend on absolute call site counts
  • 7212561: 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah
  • e36cbd8: 8242847: G1 should not clear mark bitmaps with no marks
  • 2ef6871: 8272447: Remove 'native' ranked Mutex
  • 63e062f: 8236176: Parallel GC SplitInfo comment should be updated for shadow regions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 25, 2021
@TobiHartmann
Copy link
Member Author

Thanks Christian! Do you agree that this is trivial?

@chhagedorn
Copy link
Member

Thanks Christian! Do you agree that this is trivial?

Yes, absolutely! Forgot to mention it.

@DamonFool
Copy link
Member

But why the error msg is said to be 'Embedded *'?
This seems a bit strange to me.

@TobiHartmann
Copy link
Member Author

Yes, absolutely! Forgot to mention it.

Thanks, Christian.

But why the error msg is said to be 'Embedded *'?
This seems a bit strange to me.

The problem is that the " is parsed as being part of the method name and therefore the * appears embedded in the name which is not allowed. So removing the " would also fix the problem but I prefer the full name because the wildcard is not really needed.

Copy link
Member

@DamonFool DamonFool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your clarification.

Copy link

@neliasso neliasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@TobiHartmann
Copy link
Member Author

Thanks @DamonFool and @neliasso!

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 26, 2021

Going to push as commit 9166ba3.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 49b2789: 8262751: RenderPipelineState assertion error in J2DDemo
  • a3308af: 8272836: Limit run time for java/lang/invoke/LFCaching tests
  • c4c76e2: 8272811: Document the effects of building with _GNU_SOURCE in os_posix.hpp
  • 673ce7e: 8272873: C2: Inlining should not depend on absolute call site counts
  • 7212561: 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah
  • e36cbd8: 8242847: G1 should not clear mark bitmaps with no marks
  • 2ef6871: 8272447: Remove 'native' ranked Mutex
  • 63e062f: 8236176: Parallel GC SplitInfo comment should be updated for shadow regions

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 26, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 26, 2021
@openjdk
Copy link

openjdk bot commented Aug 26, 2021

@TobiHartmann Pushed as commit 9166ba3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
4 participants