8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop

[TobiHartmann]

Fixed the Embedded * not allowed compile command error and increased number of iterations to reliably trigger C2 compilation.

Thanks,
Tobias

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Jie Fu (@DamonFool - Reviewer)
• Nils Eliasson (@neliasso - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5248/head:pull/5248
$ git checkout pull/5248

Update a local copy of the PR:
$ git checkout pull/5248
$ git pull https://git.openjdk.java.net/jdk pull/5248/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5248

View PR using the GUI difftool:
$ git pr show -t 5248

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5248.diff

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TobiHartmann The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6ab62df0)

[chhagedorn]

Looks good!

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop

Reviewed-by: chagedorn, jiefu, neliasso

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 49b2789: 8262751: RenderPipelineState assertion error in J2DDemo
• a3308af: 8272836: Limit run time for java/lang/invoke/LFCaching tests
• c4c76e2: 8272811: Document the effects of building with _GNU_SOURCE in os_posix.hpp
• 673ce7e: 8272873: C2: Inlining should not depend on absolute call site counts
• 7212561: 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah
• e36cbd8: 8242847: G1 should not clear mark bitmaps with no marks
• 2ef6871: 8272447: Remove 'native' ranked Mutex
• 63e062f: 8236176: Parallel GC SplitInfo comment should be updated for shadow regions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Thanks Christian! Do you agree that this is trivial?

[chhagedorn]

Thanks Christian! Do you agree that this is trivial?

Yes, absolutely! Forgot to mention it.

[DamonFool]

But why the error msg is said to be 'Embedded *'?
This seems a bit strange to me.

[TobiHartmann]

Yes, absolutely! Forgot to mention it.

Thanks, Christian.

But why the error msg is said to be 'Embedded *'?
This seems a bit strange to me.

The problem is that the " is parsed as being part of the method name and therefore the * appears embedded in the name which is not allowed. So removing the " would also fix the problem but I prefer the full name because the wildcard is not really needed.

[DamonFool]

Thanks for your clarification.

[neliasso]

Looks good!

[TobiHartmann]

Thanks @DamonFool and @neliasso!

[TobiHartmann]

/integrate

[openjdk]

Going to push as commit 9166ba3.
Since your change was applied there have been 8 commits pushed to the master branch:

• 49b2789: 8262751: RenderPipelineState assertion error in J2DDemo
• a3308af: 8272836: Limit run time for java/lang/invoke/LFCaching tests
• c4c76e2: 8272811: Document the effects of building with _GNU_SOURCE in os_posix.hpp
• 673ce7e: 8272873: C2: Inlining should not depend on absolute call site counts
• 7212561: 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah
• e36cbd8: 8242847: G1 should not clear mark bitmaps with no marks
• 2ef6871: 8272447: Remove 'native' ranked Mutex
• 63e062f: 8236176: Parallel GC SplitInfo comment should be updated for shadow regions

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann Pushed as commit 9166ba3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.