Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262186: Call X509KeyManager.chooseClientAlias once for all key types #5257

Closed
wants to merge 5 commits into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Aug 25, 2021

This code change collects all key types and runs chooseClientAlias only once.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262186: Call X509KeyManager.chooseClientAlias once for all key types

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5257/head:pull/5257
$ git checkout pull/5257

Update a local copy of the PR:
$ git checkout pull/5257
$ git pull https://git.openjdk.java.net/jdk pull/5257/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5257

View PR using the GUI difftool:
$ git pr show -t 5257

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5257.diff

…Alias(...)

8262186: Callback semantics of the method X509KeyManager.chooseClientAlias(...)
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2021

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 25, 2021

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Aug 25, 2021
@wangweij wangweij marked this pull request as ready for review August 26, 2021 20:15
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 26, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 26, 2021

Webrevs

@wangweij
Copy link
Contributor Author

New commit pushed. A lot of code reorg. Now X509PossessionGenerator::createPossession is also calling the new static methods.

@seanjmullan
Copy link
Member

The bug title could be improved to better describe the change, ex: "Call X509KeyManager.chooseClientAlias once for all key types". This also probably should have a CSR (and a release note) since it is technically a behavior change, even though it is reverting to prior behavior.

@wangweij wangweij changed the title 8262186: Callback semantics of the method X509KeyManager.chooseClientAlias(...) 8262186: Call X509KeyManager.chooseClientAlias once for all key types Aug 30, 2021
@wangweij
Copy link
Contributor Author

/csr

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Aug 30, 2021
@openjdk
Copy link

openjdk bot commented Aug 30, 2021

@wangweij this pull request will not be integrated until the CSR request JDK-8273149 for issue JDK-8262186 has been approved.

@wangweij
Copy link
Contributor Author

New commit pushed. Comment resolved. X509Authentication constructor simplified. Please also review the CSR at https://bugs.openjdk.java.net/browse/JDK-8273149.

Copy link
Member

@XueleiFan XueleiFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except a minion naming comment.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Aug 31, 2021
@openjdk
Copy link

openjdk bot commented Aug 31, 2021

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262186: Call X509KeyManager.chooseClientAlias once for all key types

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 81 new commits pushed to the master branch:

  • 683e30d: 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302
  • 1996f64: 8273092: Sort classlist in JDK image
  • ba3587e: 8273144: Remove unused top level "Sample Collection Set Candidates" logging
  • 75d987a: 8262095: NPE in Flow$FlowAnalyzer.visitApply: Cannot invoke getThrownTypes because tree.meth.type is null
  • e551852: 8271225: Add floorDivExact() method to java.lang.[Strict]Math
  • e671255: 8237567: Refactor G1-specific code in shared VM_CollectForMetadataAllocation
  • 9bc7cc5: 8273033: SerialGC: remove obsolete comments
  • 841e394: 8159979: During initial mark, preparing all regions for marking may take a significant amount of time
  • 98fa533: 8273100: Improve AbstractStringBuilder.append(String) when using CompactStrings
  • 9732fbe: 8273153: Consolidate file_exists into os:file_exists
  • ... and 71 more: https://git.openjdk.java.net/jdk/compare/594e5161b48382d61509b4969bc8f52c3c076452...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 31, 2021
@wangweij
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 31, 2021

Going to push as commit 3d657eb.
Since your change was applied there have been 82 commits pushed to the master branch:

  • c1e0aac: 8273186: Remove leftover comment about sparse remembered set in G1 HeapRegionRemSet
  • 683e30d: 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302
  • 1996f64: 8273092: Sort classlist in JDK image
  • ba3587e: 8273144: Remove unused top level "Sample Collection Set Candidates" logging
  • 75d987a: 8262095: NPE in Flow$FlowAnalyzer.visitApply: Cannot invoke getThrownTypes because tree.meth.type is null
  • e551852: 8271225: Add floorDivExact() method to java.lang.[Strict]Math
  • e671255: 8237567: Refactor G1-specific code in shared VM_CollectForMetadataAllocation
  • 9bc7cc5: 8273033: SerialGC: remove obsolete comments
  • 841e394: 8159979: During initial mark, preparing all regions for marking may take a significant amount of time
  • 98fa533: 8273100: Improve AbstractStringBuilder.append(String) when using CompactStrings
  • ... and 72 more: https://git.openjdk.java.net/jdk/compare/594e5161b48382d61509b4969bc8f52c3c076452...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 31, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 31, 2021
@openjdk
Copy link

openjdk bot commented Aug 31, 2021

@wangweij Pushed as commit 3d657eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the 8262186 branch August 31, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
3 participants