Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274050: Unnecessary Vector usage in javax.crypto #5261

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Aug 26, 2021

In JDK-8268873 I missed a few places, where Vector could be replaced with ArrayList.
Usage of thread-safe collection Vector is unnecessary. It's recommended to use ArrayList if a thread-safe implementation is not needed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274050: Unnecessary Vector usage in javax.crypto

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5261/head:pull/5261
$ git checkout pull/5261

Update a local copy of the PR:
$ git checkout pull/5261
$ git pull https://git.openjdk.java.net/jdk pull/5261/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5261

View PR using the GUI difftool:
$ git pr show -t 5261

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5261.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 26, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2021

@turbanoff The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Aug 26, 2021
@turbanoff turbanoff changed the title [PATCH] Unnecessary Vector usage in javax.crypto 8274050: Unnecessary Vector usage in javax.crypto Sep 21, 2021
@openjdk openjdk bot added the rfr label Sep 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 21, 2021

Webrevs

Copy link

@valeriepeng valeriepeng left a comment

Just some nit. Rest looks fine. Thanks.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274050: Unnecessary Vector usage in javax.crypto

Reviewed-by: valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 417 new commits pushed to the master branch:

  • 97b2874: 8274509: Remove stray * and stylistic . from doc comments
  • b1b6696: 8274453: (sctp) com/sun/nio/sctp/SctpChannel/CloseDescriptors.java test should be resilient to lsof warnings
  • edd9d1c: 8274330: Incorrect encoding of the DistributionPointName object in IssuingDistributionPointExtension
  • 980c50d: 8272562: C2: assert(false) failed: Bad graph detected in build_loop_late
  • 1dc8fa9: 8274340: [BACKOUT] JDK-8271880: Tighten condition for excluding regions from collecting cards with cross-references
  • aaa36cc: 8274242: Implement fast-path for ASCII-compatible CharsetEncoders on x86
  • c4d1157: 8271855: [TESTBUG] Wrong weakCompareAndSet assumption in UnsafeIntrinsicsTest
  • 756d22c: 8274130: C2: MulNode::Ideal chained transformations may act on wrong nodes
  • 5b0c9cc: 8274172: Convert JavadocTester to use NIO
  • 2657bcb: 8274136: -XX:+ExitOnOutOfMemoryError calls exit while threads are running
  • ... and 407 more: https://git.openjdk.java.net/jdk/compare/e36cbd8e05774ea9847c69f9987a2242589acf7e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@valeriepeng) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 28, 2021
@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Sep 29, 2021

/integrate

@openjdk openjdk bot added the sponsor label Sep 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2021

@turbanoff
Your change (at version 9e01a41) is now ready to be sponsored by a Committer.

@valeriepeng
Copy link

@valeriepeng valeriepeng commented Sep 29, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2021

Going to push as commit 79cebe2.
Since your change was applied there have been 417 commits pushed to the master branch:

  • 97b2874: 8274509: Remove stray * and stylistic . from doc comments
  • b1b6696: 8274453: (sctp) com/sun/nio/sctp/SctpChannel/CloseDescriptors.java test should be resilient to lsof warnings
  • edd9d1c: 8274330: Incorrect encoding of the DistributionPointName object in IssuingDistributionPointExtension
  • 980c50d: 8272562: C2: assert(false) failed: Bad graph detected in build_loop_late
  • 1dc8fa9: 8274340: [BACKOUT] JDK-8271880: Tighten condition for excluding regions from collecting cards with cross-references
  • aaa36cc: 8274242: Implement fast-path for ASCII-compatible CharsetEncoders on x86
  • c4d1157: 8271855: [TESTBUG] Wrong weakCompareAndSet assumption in UnsafeIntrinsicsTest
  • 756d22c: 8274130: C2: MulNode::Ideal chained transformations may act on wrong nodes
  • 5b0c9cc: 8274172: Convert JavadocTester to use NIO
  • 2657bcb: 8274136: -XX:+ExitOnOutOfMemoryError calls exit while threads are running
  • ... and 407 more: https://git.openjdk.java.net/jdk/compare/e36cbd8e05774ea9847c69f9987a2242589acf7e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Sep 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2021

@valeriepeng @turbanoff Pushed as commit 79cebe2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the avoid-unnecessary-vector-usage-in-javax-crypto branch Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
3 participants