Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273299: Unnecessary Vector usage in java.security.jgss #5264

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Aug 26, 2021

Usage of thread-safe collection Vector is unnecessary. It's recommended to use ArrayList if a thread-safe implementation is not needed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273299: Unnecessary Vector usage in java.security.jgss

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5264/head:pull/5264
$ git checkout pull/5264

Update a local copy of the PR:
$ git checkout pull/5264
$ git pull https://git.openjdk.java.net/jdk pull/5264/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5264

View PR using the GUI difftool:
$ git pr show -t 5264

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5264.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 26, 2021

@turbanoff The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Aug 26, 2021
@turbanoff turbanoff changed the title [PATCH] Unnecessary Vector usage in java.security.jgss 8273299: Unnecessary Vector usage in java.security.jgss Sep 2, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 2, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 2, 2021

Webrevs

use result of toArray to make sure our array is properly filled
@wangweij
Copy link
Contributor

wangweij commented Sep 24, 2021

Looks fine to me. I'll run a round of test now. Update: all pass.

And BTW, I've added a noreg-cleanup label to the bug.

@openjdk
Copy link

openjdk bot commented Sep 24, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273299: Unnecessary Vector usage in java.security.jgss

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 369 new commits pushed to the master branch:

  • e3aff8f: 8274289: jdk/jfr/api/consumer/TestRecordedFrameType.java failed with "RuntimeException: assertNotEquals: expected Interpreted to not equal Interpreted"
  • 252aaa9: 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated
  • 7700b25: 8273401: Disable JarIndex support in URLClassPath
  • 5ec1cdc: 8274321: Standardize values of @SInCE tags in javax.lang.model
  • 4838a2c: 8274143: Disable "invalid entry for security.provider.X" error message in log file when security.provider.X is empty
  • ab28db1: 8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all
  • 8c122af: 8274314: Typo in WatchService#poll(long timeout, TimeUnit unit) javadoc
  • 9bc865d: 8273960: Redundant condition in Metadata.TypeComparator.compare
  • 5756385: 8274273: Update testing docs for MacOS with Non-US locale
  • 61ac53f: 8210927: JDB tests do not update source path after doing a redefine class
  • ... and 359 more: https://git.openjdk.java.net/jdk/compare/49b2789a49e4e476dfcdf0a65e061a40264a4683...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@wangweij) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 24, 2021
@turbanoff
Copy link
Member Author

turbanoff commented Sep 26, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 27, 2021
@openjdk
Copy link

openjdk bot commented Sep 27, 2021

@turbanoff
Your change (at version 91bfda8) is now ready to be sponsored by a Committer.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2021

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@wangweij
Copy link
Contributor

wangweij commented Oct 26, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 26, 2021

Going to push as commit c9dec2f.
Since your change was applied there have been 736 commits pushed to the master branch:

  • b98ed55: 8275819: [TableRowAccessibility accessibilityChildren] method is ineffective
  • 71d593e: 8275162: Use varargs in 'def' macros in mutexLocker.cpp
  • 7ca053d: 8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR
  • 4be88d5: 8275047: Optimize existing fill stubs for AVX-512 target
  • 63e0f34: 8275767: JDK source code contains redundant boolean operations in jdk.charsets
  • 4961373: 8275137: jdk.unsupported/sun.reflect.ReflectionFactory.readObjectNoDataForSerialization uses wrong signature
  • 174f553: 8275869: Problem list applications/jcstress/copy.java on Linux-aarch64
  • 3ff085e: 8275582: Don't purge metaspace mapping lists
  • 10e1610: 8251134: Unwrapping a key with a Private Key generated by Microsoft CNG fails
  • 4361945: 8185844: MSCAPI doesn't list aliases correctly
  • ... and 726 more: https://git.openjdk.java.net/jdk/compare/49b2789a49e4e476dfcdf0a65e061a40264a4683...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 26, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 26, 2021
@openjdk
Copy link

openjdk bot commented Oct 26, 2021

@wangweij @turbanoff Pushed as commit c9dec2f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the avoid-unnecessary-vector-usage-in-java.security.jgss branch Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
3 participants