Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273020: LibraryCallKit::sharpen_unsafe_type does not handle narrow oop array #5265

Closed
wants to merge 1 commit into from

Conversation

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Aug 26, 2021

The array handling code in LibraryCallKit::sharpen_unsafe_type does not work with narrow oop arrays because isa_oopptr returns NULL. Instead, make_oopptr should be used.

I've only noticed this while working on Valhalla, I don't think there is any impact on mainline code.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273020: LibraryCallKit::sharpen_unsafe_type does not handle narrow oop array

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5265/head:pull/5265
$ git checkout pull/5265

Update a local copy of the PR:
$ git checkout pull/5265
$ git pull https://git.openjdk.java.net/jdk pull/5265/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5265

View PR using the GUI difftool:
$ git pr show -t 5265

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5265.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 26, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Aug 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2021

@TobiHartmann The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 26, 2021

Webrevs

Loading

Copy link
Member

@chhagedorn chhagedorn left a comment

Looks good and trivial!

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273020: LibraryCallKit::sharpen_unsafe_type does not handle narrow oop array

Reviewed-by: chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 9166ba3: 8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Aug 26, 2021

Thanks Christian!

Loading

@openjdk openjdk bot added the ready label Aug 26, 2021
@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Aug 27, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 27, 2021

Going to push as commit c925c7f.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 76baace: 8273045: Fix misc javadoc bugs in the java.security and javax.net.ssl code
  • b16a04e: 8271186: Add UL option to replace newline char
  • d732c30: 8272863: Replace usages of Collections.sort with List.sort call in public java modules
  • fe7d708: 8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong
  • 845e1ce: 8272983: G1 Add marking details to eager reclaim logging
  • c420530: 8272481: [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java fails
  • e43a907: 8271315: Redo: Nimbus JTree renderer properties persist across L&F changes
  • 11c9fd8: 8272975: ParallelGC: add documentation to heap memory layout
  • b94fd32: 8272859: Javadoc external links should only have feature version number in URL
  • 9166ba3: 8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Aug 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 27, 2021

@TobiHartmann Pushed as commit c925c7f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants