8238436: java/awt/Frame/FrameLocationTest/FrameLocationTest.java fails

[pankaj-bansal]

The test fail intermittently on all platforms, though issue is filled for only Ubuntu.
The test generated random numbers and sets the frame location to those random numbers. There are two issues in the test.

1. The test has logic to make sure maximum location coordinates are such that the frame will always fit in the screen. There is no logic to set the minimum possible location for frame because of taskbar. Eg, on my Mac, if the y coordinate is < 23, the frame y location is set to 23 on frame.setLocation(), so the test will fail. The minimum x,y location coordinate will depend upon the platform.
2. The test is setting the frame location and then verifying the location in a loop, but there is no wait/delay added to let the frame.setLocation complete.

The fix sets the minimum location coordinates possible for the frame by using the frame location it is shown first time. Also, Robot is added to use delay/wait to let setLocation complete. The mach5 passes after the fix with multiple runs of the test. Link in JBS.

The test is moved from closed to open repo, so looks like a new test.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Windows x64	macOS x64
Build	✔️ (3/3 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	❌ (1/9 failed)	✔️ (9/9 passed)

Failed test task

• Windows x64 (langtools/tier1)

Issue

• JDK-8238436: java/awt/Frame/FrameLocationTest/FrameLocationTest.java fails

Download

$ git fetch https://git.openjdk.java.net/jdk pull/527/head:pull/527
$ git checkout pull/527

[bridgekeeper]

👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@pankaj-bansal The following label will be automatically applied to this pull request:

• awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (44fb227)

[mrserb]

The test is setting the frame location and then verifying the location in a loop, but there is no wait/delay added to let the >frame.setLocation complete.
It is intentionally was implemented that way, the setLocation sets the property "location" for the frame, it is stored in the frame itself, the getLocation() method if called immediately after setLocation() should return that property.

[pankaj-bansal]

The test is setting the frame location and then verifying the location in a loop, but there is no wait/delay added to let the >frame.setLocation complete.
It is intentionally was implemented that way, the setLocation sets the property "location" for the frame, it is stored in the frame itself, the getLocation() method if called immediately after setLocation() should return that property.

ok, so we should not add delay after setLocation. But then the frame is not repainted at new location at all. The test will just set and get the location without actually moving the frame to the location. The test is unstable in this scenario.

[mrserb]

ok, so we should not add delay after setLocation. But then the frame is not repainted at new location at all. The test will just set and get the location without actually moving the frame to the location. The test is unstable in this scenario.

If it just sets/gets location then why it is unstable?