-
Notifications
You must be signed in to change notification settings - Fork 6k
8273045: Fix misc javadoc bugs in the java.security and javax.net.ssl code #5271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back wetmore! A progress list of the required criteria for merging this PR into |
@bradfordwetmore The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you for the clean up.
@@ -34,6 +34,7 @@ | |||
import java.util.Locale; | |||
import java.util.Objects; | |||
import java.util.regex.Pattern; | |||
import java.util.regex.PatternSyntaxException; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it mean that the classes introduced in java doc should also be imported? Maybe, the path package names could be removed in the createSNIMatcher() method spec.
- * @throws java.util.regex.PatternSyntaxException if the regular expression's
- * syntax is invalid
+ * @throws PatternSyntaxException if the regular expression's syntax is invalid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch.
It doesn't absolutely have to be fixed to get javadoc to run (it apparently is a good guesser), but 3rd party tools like IntelliJ Idea aren't as robust, and treat this as an error.
In the second update, I removed the extra package name in setSNIMatcher.
Thanks for the review. I'll go ahead and push.
@bradfordwetmore This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@bradfordwetmore Pushed as commit 76baace. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Did a quick sweep of some minor non-standard javadoc issues. This silences 3rd party tooling warnings and fixes some linkage issues.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5271/head:pull/5271
$ git checkout pull/5271
Update a local copy of the PR:
$ git checkout pull/5271
$ git pull https://git.openjdk.java.net/jdk pull/5271/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5271
View PR using the GUI difftool:
$ git pr show -t 5271
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5271.diff