8273059: Redundant Math.min call in Http2ClientImpl#getConnectionWindowSize

[Michael-Mc-Mahon]

Hi,

Could I get the following trivial change reviewed please?
It removes a redundant call to Math.min(Integer.MAX_VALUE, ....)

Thanks,
Michael.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8273059: Redundant Math.min call in Http2ClientImpl#getConnectionWindowSize

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5277/head:pull/5277
$ git checkout pull/5277

Update a local copy of the PR:
$ git checkout pull/5277
$ git pull https://git.openjdk.java.net/jdk pull/5277/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5277

View PR using the GUI difftool:
$ git pr show -t 5277

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5277.diff

[bridgekeeper]

👋 Welcome back michaelm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Michael-Mc-Mahon The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (c671f021)
• 01: Full - Incremental (462020a7)
• 00: Full (365b6a16)

[openjdk]

@Michael-Mc-Mahon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273059: Redundant Math.min call in Http2ClientImpl#getConnectionWindowSize

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• f55d5ab: 8272838: Move CriticalJNI tests out of tier1
• a9188f2: 8268894: forged ASTs can provoke an AIOOBE at com.sun.tools.javac.jvm.ClassWriter::writePosition
• 1fb798d: 8272915: (doc) package-info typo in extLink
• 5116784: 8273091: Doc of [Strict]Math.floorDiv(long,int) erroneously documents int in @return tag
• e66c8af: 8272866: java.util.random package summary contains incorrect mixing function in table
• d1aeca1: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication
• dfeb413: 8272964: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted
• a033aa5: 8273072: Avoid using += in configure
• b92214a: 8272480: Remove Mutex::access rank
• 596b075: 8258465: Headless build fails due to missing X11 headers on linux

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dfuch]

You need to keep line 510 - since completed is always false this line should be executed always.

[Michael-Mc-Mahon]

/integrate

[openjdk]

Going to push as commit 16e8305.
Since your change was applied there have been 10 commits pushed to the master branch:

• f55d5ab: 8272838: Move CriticalJNI tests out of tier1
• a9188f2: 8268894: forged ASTs can provoke an AIOOBE at com.sun.tools.javac.jvm.ClassWriter::writePosition
• 1fb798d: 8272915: (doc) package-info typo in extLink
• 5116784: 8273091: Doc of [Strict]Math.floorDiv(long,int) erroneously documents int in @return tag
• e66c8af: 8272866: java.util.random package summary contains incorrect mixing function in table
• d1aeca1: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication
• dfeb413: 8272964: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted
• a033aa5: 8273072: Avoid using += in configure
• b92214a: 8272480: Remove Mutex::access rank
• 596b075: 8258465: Headless build fails due to missing X11 headers on linux

Your commit was automatically rebased without conflicts.

[openjdk]

@Michael-Mc-Mahon Pushed as commit 16e8305.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.