Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254081: java/security/cert/PolicyNode/GetPolicyQualifiers.java fails due to an expired certificate #528

Closed
wants to merge 2 commits into from

Conversation

@rhalade
Copy link
Member

@rhalade rhalade commented Oct 6, 2020

/issues add 8254081


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8254081: java/security/cert/PolicyNode/GetPolicyQualifiers.java fails due to an expired certificate

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/528/head:pull/528
$ git checkout pull/528

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 6, 2020

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@rhalade Unknown command issues - for a list of valid commands use /help.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Oct 6, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 6, 2020

Webrevs

@rhalade
Copy link
Member Author

@rhalade rhalade commented Oct 6, 2020

/summary Perform backdated validation of test certificate.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@rhalade Setting summary to Perform backdated validation of test certificate.

@@ -52,6 +53,8 @@ public static void main(String[] args) throws Exception {
PKIXParameters params = new PKIXParameters(trustAnchors);
params.setPolicyQualifiersRejected(false);
params.setRevocationEnabled(false);
// Certificates expired on Oct 6th, 2020
params.setDate(new Date("July 01, 2020"));
Copy link
Member

@XueleiFan XueleiFan Oct 6, 2020

The Date() constructor is deprecated, would you like to use the replacement method DateFormat.parse()?

Copy link
Member Author

@rhalade rhalade Oct 6, 2020

I have fixed it, thanks!

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8254081: java/security/cert/PolicyNode/GetPolicyQualifiers.java fails due to an expired certificate

Perform backdated validation of test certificate.

Reviewed-by: mullan, xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 51fdb4c: 8254075: Shenandoah: Remove ShenandoahCodeRootsStyle diagnostic flag and related test
  • 77921b9: 8254080: fix for JDK-8204256 causes jlink test failures

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 6, 2020
@rhalade
Copy link
Member Author

@rhalade rhalade commented Oct 6, 2020

/merge

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@rhalade Unknown command merge - for a list of valid commands use /help.

@rhalade
Copy link
Member Author

@rhalade rhalade commented Oct 6, 2020

/help

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@rhalade Available commands:

  • cc - add or remove an additional classification label
  • contributor - adds or removes additional contributors for a PR
  • covered - used when employer has signed the OCA
  • csr - require a compatibility and specification request (CSR) for this pull request
  • help - shows this text
  • integrate - performs integration of the changes in the PR
  • issue - edit the list of issues that this PR solves
  • label - add or remove an additional classification label
  • reviewer - manage additional reviewers for a PR
  • reviewers - set the number of additional required reviewers for this PR
  • signed - used after signing the OCA
  • solves - edit the list of issues that this PR solves
  • sponsor - performs integration of a PR that is authored by a non-committer
  • summary - updates the summary in the commit message
  • test - used to run tests

@rhalade
Copy link
Member Author

@rhalade rhalade commented Oct 6, 2020

/integrate

@openjdk openjdk bot closed this Oct 6, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@rhalade Since your change was applied there have been 2 commits pushed to the master branch:

  • 51fdb4c: 8254075: Shenandoah: Remove ShenandoahCodeRootsStyle diagnostic flag and related test
  • 77921b9: 8254080: fix for JDK-8204256 causes jlink test failures

Your commit was automatically rebased without conflicts.

Pushed as commit 54b340b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rhalade rhalade deleted the JDK-8254081 branch Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants