Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274161: Cleanup redundant casts in jdk.compiler #5283

Conversation

@turbanoff
Copy link
Contributor

@turbanoff turbanoff commented Aug 27, 2021

Such casts are actually redundant, but they are inserted, because variable is declared with too weak type.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5283/head:pull/5283
$ git checkout pull/5283

Update a local copy of the PR:
$ git checkout pull/5283
$ git pull https://git.openjdk.java.net/jdk pull/5283/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5283

View PR using the GUI difftool:
$ git pr show -t 5283

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5283.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 27, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 27, 2021

@turbanoff The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the compiler label Aug 27, 2021
@turbanoff turbanoff changed the title [PATCH] Cleanup redundant casts in java.compiler 8274161: Cleanup redundant casts in java.compiler Sep 22, 2021
@openjdk openjdk bot added the rfr label Sep 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 22, 2021

Webrevs

Loading

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

looks good

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274161: Cleanup redundant casts in jdk.compiler

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 350 new commits pushed to the master branch:

  • e3aff8f: 8274289: jdk/jfr/api/consumer/TestRecordedFrameType.java failed with "RuntimeException: assertNotEquals: expected Interpreted to not equal Interpreted"
  • 252aaa9: 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated
  • 7700b25: 8273401: Disable JarIndex support in URLClassPath
  • 5ec1cdc: 8274321: Standardize values of @SInCE tags in javax.lang.model
  • 4838a2c: 8274143: Disable "invalid entry for security.provider.X" error message in log file when security.provider.X is empty
  • ab28db1: 8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all
  • 8c122af: 8274314: Typo in WatchService#poll(long timeout, TimeUnit unit) javadoc
  • 9bc865d: 8273960: Redundant condition in Metadata.TypeComparator.compare
  • 5756385: 8274273: Update testing docs for MacOS with Non-US locale
  • 61ac53f: 8210927: JDB tests do not update source path after doing a redefine class
  • ... and 340 more: https://git.openjdk.java.net/jdk/compare/d1aeca117ccc4334d67b2692ff087a9f8d808a59...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vicente-romero-oracle, @jonathan-gibbons) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Sep 22, 2021
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

The module name in the summary (java.compiler) does not match the module name in the edited files (jdk.compiler)

Loading

@turbanoff turbanoff changed the title 8274161: Cleanup redundant casts in java.compiler 8274161: Cleanup redundant casts in jdk.compiler Sep 23, 2021
@turbanoff
Copy link
Contributor Author

@turbanoff turbanoff commented Sep 23, 2021

The module name in the summary (java.compiler) does not match the module name in the edited files (jdk.compiler)

Oops. Updated.

Loading

@turbanoff
Copy link
Contributor Author

@turbanoff turbanoff commented Sep 26, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Sep 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 27, 2021

@turbanoff
Your change (at version 88a2139) is now ready to be sponsored by a Committer.

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 25, 2021

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Loading

@turbanoff
Copy link
Contributor Author

@turbanoff turbanoff commented Nov 15, 2021

keep open

Loading

@vicente-romero-oracle
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Nov 24, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Nov 24, 2021

Going to push as commit 077b2de.
Since your change was applied there have been 1113 commits pushed to the master branch:

  • 951247c: 8235876: Misleading warning message in java source-file mode
  • 663e33d: 8272728: javac ignores any -J option in @argfiles silently
  • 0384739: 8276665: ObjectInputStream.GetField.get(name, object) should throw ClassNotFoundException
  • cf7adae: 8275320: NMT should perform buffer overrun checks
  • 96e3607: 8275063: Implementation of Foreign Function & Memory API (Second incubator)
  • 17e68ca: 8277042: add test for 8276036 to compiler/codecache
  • 8a8bc29: 8277562: Remove dead method c1 If::swap_sux
  • d085c2b: 8273328: Compiler implementation for Pattern Matching for switch (Second Preview)
  • 6d73460: 8277399: ZGC: Move worker thread logging out of gc+phase=debug
  • 712b875: 8277397: ZGC: Add JFR event for temporary latency measurements
  • ... and 1103 more: https://git.openjdk.java.net/jdk/compare/d1aeca117ccc4334d67b2692ff087a9f8d808a59...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Nov 24, 2021

@vicente-romero-oracle @turbanoff Pushed as commit 077b2de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants