Skip to content

8271356: JDB: GDB-style command repetition and list auto-advance #5289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

8271356: JDB: GDB-style command repetition and list auto-advance #5289

wants to merge 0 commits into from

Conversation

jakobcornell
Copy link
Contributor

@jakobcornell jakobcornell commented Aug 28, 2021

This has been under discussion on and off for the past month or so on serviceability-dev, and I think a CSR request is required, so this may be a work in progress.

Notes on the patch:

  • The list command previously marked a line in each listing with =>. In a bare list this is the next line up for execution. Previously when requesting a specific location (e.g. list 5) the requested line would be marked. With the patch applied, list will only ever mark the next line up for execution. This is consistent with the behavior of GDB and PDB (at least).
  • EOF is printed when the repeat setting is on and a bare list command follows a listing containing the last source line. This feature is from PDB; it's a somewhat softer message than the one for an explicit list request that's out of range.
  • I don't speak Chinese or Japanese, so I've omitted localizations for the new messages in those locales. However, I updated the help text in both to include the new commands, with the descriptions left empty for now.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8271356

Issue

  • JDK-8271356: Modify jdb to treat an empty command as a repeat of the previous command ⚠️ Title mismatch between PR and JBS.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5289/head:pull/5289
$ git checkout pull/5289

Update a local copy of the PR:
$ git checkout pull/5289
$ git pull https://git.openjdk.java.net/jdk pull/5289/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5289

View PR using the GUI difftool:
$ git pr show -t 5289

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5289.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 28, 2021

👋 Welcome back jakobcornell! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 28, 2021

⚠️ @jakobcornell a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 90cd2fa16458dcc3e36171fa4bf21f26bc92b168
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 28, 2021
@openjdk
Copy link

openjdk bot commented Aug 28, 2021

@jakobcornell The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Aug 28, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 28, 2021

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

1 participant