8271356: JDB: GDB-style command repetition and list
auto-advance
#5289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been under discussion on and off for the past month or so on serviceability-dev, and I think a CSR request is required, so this may be a work in progress.
Notes on the patch:
list
command previously marked a line in each listing with=>
. In a barelist
this is the next line up for execution. Previously when requesting a specific location (e.g.list 5
) the requested line would be marked. With the patch applied,list
will only ever mark the next line up for execution. This is consistent with the behavior of GDB and PDB (at least).EOF
is printed when the repeat setting is on and a barelist
command follows a listing containing the last source line. This feature is from PDB; it's a somewhat softer message than the one for an explicitlist
request that's out of range.Progress
Integration blocker
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5289/head:pull/5289
$ git checkout pull/5289
Update a local copy of the PR:
$ git checkout pull/5289
$ git pull https://git.openjdk.java.net/jdk pull/5289/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5289
View PR using the GUI difftool:
$ git pr show -t 5289
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5289.diff