-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8254084: Remove TemplateTable::pd_initialize #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back redestad! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up. Should get removed from templateTable.hpp, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Echo @TheRealMDoerr wrt templateTable.hpp. Also trivial.
@cl4es This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Fixed |
/integrate |
@cl4es Since your change was applied there have been 6 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 6712f8c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
TemplateTable::pd_initialize is empty on all platforms, and has been so for some time. I suggest removing them.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/529/head:pull/529
$ git checkout pull/529