Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273102: Delete deprecated for removal the empty finalize() in java.desktop module #5292

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Aug 29, 2021

The "java.desktop" module has a few implementations of the finalize() which do nothing, deprecated since jdk9, and are marked "forRemoval = true" since jdk16.

This is a request to delete such empty methods.

CSR: https://bugs.openjdk.java.net/browse/JDK-8273103


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273102: Delete deprecated for removal the empty finalize() in java.desktop module

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5292/head:pull/5292
$ git checkout pull/5292

Update a local copy of the PR:
$ git checkout pull/5292
$ git pull https://git.openjdk.java.net/jdk pull/5292/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5292

View PR using the GUI difftool:
$ git pr show -t 5292

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5292.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 29, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 29, 2021

@mrserb The following label will be automatically applied to this pull request:

  • 2d

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the 2d client-libs-dev@openjdk.org label Aug 29, 2021
@mrserb mrserb marked this pull request as ready for review Aug 30, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 30, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 30, 2021

Webrevs

@mrserb
Copy link
Member Author

@mrserb mrserb commented Aug 30, 2021

/csr

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Aug 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 30, 2021

@mrserb this pull request will not be integrated until the CSR request JDK-8273103 for issue JDK-8273102 has been approved.

Copy link

@pankaj-bansal pankaj-bansal left a comment

Looks good to me

Copy link
Member

@irisclark irisclark left a comment

Associated CSR also reviewed.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 10, 2021
prrace
prrace approved these changes Sep 12, 2021
@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Sep 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 18, 2021

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273102: Delete deprecated for removal the empty finalize() in java.desktop module

Reviewed-by: pbansal, aivanov, iris, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 236 new commits pushed to the master branch:

  • 2a2e919: 8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction
  • 8302061: 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms
  • 2f8c221: 8273681: Add Vector API vs Arrays.mismatch intrinsic benchmark
  • 17f7a45: 8273913: Problem list some headful client jtreg tests that fail on macOS 12
  • 27d747a: 8273877: os::unsetenv unused
  • 35f6f1d: 8273808: Cleanup AddFontsToX11FontPath
  • 1890d85: 8273872: ZGC: Explicitly use 2M large pages
  • 54b4567: 8273880: Zero: Print warnings when unsupported intrinsics are enabled
  • e07ab82: 8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record
  • 8c022e2: 8270434: JDI+UT: Unexpected event in JDI tests
  • ... and 226 more: https://git.openjdk.java.net/jdk/compare/1fb798d320c708dfcbc0bb157511a2937fafb9e6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 18, 2021
@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Oct 5, 2021

@mrserb Are we waiting on something to integrate this change?

@mrserb
Copy link
Member Author

@mrserb mrserb commented Oct 6, 2021

@prrace @jayathirthrao I am going to push this change, please note it might cause some test failures in JCK.

@mrserb
Copy link
Member Author

@mrserb mrserb commented Oct 6, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

Going to push as commit 9561fea.
Since your change was applied there have been 474 commits pushed to the master branch:

  • 9945f7a: 8274318: Replace 'for' cycles with iterator with enhanced-for in java.management
  • 754bc82: 8274525: Replace uses of StringBuffer with StringBuilder in java.xml
  • 4e7d7ca: 8273711: Remove redundant stream() call before forEach in jdk.jlink
  • f3cedbe: 8274464: Remove redundant stream() call before forEach in java.* modules
  • c10de35: 8262944: Improve exception message when automatic module lists provider class not in JAR file
  • b8af6a9: 8273917: Remove 'leaf' ranking for Mutex
  • c80a612: 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm
  • 9759fcb: 8274496: Use String.contains() instead of String.indexOf() in java.desktop
  • cdf8930: 8274625: Search field placeholder behavior
  • df125f6: 8273410: IR verification framework fails with "Should find method name in validIrRulesMap"
  • ... and 464 more: https://git.openjdk.java.net/jdk/compare/1fb798d320c708dfcbc0bb157511a2937fafb9e6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 6, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

@mrserb Pushed as commit 9561fea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8273102 branch Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d client-libs-dev@openjdk.org client client-libs-dev@openjdk.org integrated Pull request has been integrated
6 participants