Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270438: "Cores to use" output in configure is misleading #5301

Closed

Conversation

@magicus
Copy link
Member

@magicus magicus commented Aug 30, 2021

Description from the bug:

When building the JDK and running configure the output includes (example):

Build performance summary: 
 * Cores to use: 4 
 * Memory limit: 32768 MB 

The "Cores to use" value is misleading; it is not actually the number of cores specified using --with-num-cores, but instead the number of jobs, which (unless explicitly specified), is calculated based on the available memory and the number of cores.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270438: "Cores to use" output in configure is misleading

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5301/head:pull/5301
$ git checkout pull/5301

Update a local copy of the PR:
$ git checkout pull/5301
$ git pull https://git.openjdk.java.net/jdk pull/5301/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5301

View PR using the GUI difftool:
$ git pr show -t 5301

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5301.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 30, 2021

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Aug 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 30, 2021

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the build label Aug 30, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 30, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 30, 2021

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270438: "Cores to use" output in configure is misleading

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 5185dbd: 8273098: Unnecessary Vector usage in java.naming

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Aug 30, 2021
@magicus
Copy link
Member Author

@magicus magicus commented Aug 30, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 30, 2021

Going to push as commit fbffa54.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 5185dbd: 8273098: Unnecessary Vector usage in java.naming

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Aug 30, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 30, 2021

@magicus Pushed as commit fbffa54.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@magicus magicus deleted the 8270438-cores-to-use-is-misleading branch Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants