8273153: Consolidate file_exists into os:file_exists

[yminqi]

This are several places to check if file exists using local similar function, file_exists. They should be consolidated into one version. The patch added a function os::file_exists to do so.

Tests: tier1

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8273153: Consolidate file_exists into os:file_exists

Reviewers

• Ioi Lam (@iklam - Reviewer)
• Calvin Cheung (@calvinccheung - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5308/head:pull/5308
$ git checkout pull/5308

Update a local copy of the PR:
$ git checkout pull/5308
$ git pull https://git.openjdk.java.net/jdk pull/5308/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5308

View PR using the GUI difftool:
$ git pr show -t 5308

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5308.diff

[bridgekeeper]

👋 Welcome back minqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@yminqi The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a69be517)

[iklam]

LGTM.

[openjdk]

@yminqi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273153: Consolidate file_exists into os:file_exists

Reviewed-by: iklam, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 0609421: 8272347: ObjectMethods::bootstrap should specify NPE if any argument except lookup is null
• 7fc8540: 8260265: UTF-8 by Default
• 3204853: 8272343: Remove MetaspaceClosure::FLAG_MASK

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[calvinccheung]

LGTM.

[yminqi]

@iklam @calvinccheung Thanks for review
/integrate

[openjdk]

Going to push as commit 9732fbe.
Since your change was applied there have been 3 commits pushed to the master branch:

• 0609421: 8272347: ObjectMethods::bootstrap should specify NPE if any argument except lookup is null
• 7fc8540: 8260265: UTF-8 by Default
• 3204853: 8272343: Remove MetaspaceClosure::FLAG_MASK

Your commit was automatically rebased without conflicts.

[openjdk]

@yminqi Pushed as commit 9732fbe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.