Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273168: Remove superfluous use of boxing in java.desktop #5313

Closed

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Aug 31, 2021

parseInt/parseLong/parseShort/parseByte/parseFloat should be preferred, as they return primitives. While valueOf returns boxed object.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273168: Remove superfluous use of boxing in java.desktop

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5313/head:pull/5313
$ git checkout pull/5313

Update a local copy of the PR:
$ git checkout pull/5313
$ git pull https://git.openjdk.java.net/jdk pull/5313/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5313

View PR using the GUI difftool:
$ git pr show -t 5313

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5313.diff

parseInt/parseLong/parseShort/parseByte/parseFloat should be preferred, as they return primitives. While valueOf returns boxed object.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 31, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 31, 2021

@turbanoff The following labels will be automatically applied to this pull request:

  • 2d
  • awt
  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added 2d swing awt labels Aug 31, 2021
@turbanoff turbanoff changed the title [PATCH] Cleanup redundant boxing in java.desktop module 8273168: Remove superfluous use of boxing in java.desktop Aug 31, 2021
@openjdk openjdk bot added the rfr label Aug 31, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 31, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273168: Remove superfluous use of boxing in java.desktop

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 56 new commits pushed to the master branch:

  • 270a9d9: 8273043: [TEST_BUG] Automate NimbusJTreeSelTextColor.java
  • df05b4d: 8271923: [macos] the text color on the selected disabled tabbed pane button remains white making text unreadable
  • 2abf3b3: 8271340: Crash PhaseIdealLoop::clone_outer_loop
  • 99fb12c: 8271341: Opcode() != Op_If && Opcode() != Op_RangeCheck) || outcnt() == 2 assert failure with Test7179138_1.java
  • 041ae20: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped
  • 377b186: 8269119: C2: Avoid redundant memory barriers in Unsafe.copyMemory0 intrinsic
  • 70157c7: 8272135: jshell: Method cannot use its overloaded version
  • 5caa77b: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream
  • a522d6b: 8273376: Zero: Disable vtable/itableStub gtests
  • 3cd95a2: 8231356: Fix broken ResourceObj::operator new[] in debug builds
  • ... and 46 more: https://git.openjdk.java.net/jdk/compare/a58cf16509f3120d69fc18bd4c2c49e9ad590f73...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 7, 2021
@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Sep 7, 2021

/integrate

@openjdk openjdk bot added the sponsor label Sep 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

@turbanoff
Your change (at version a6bdbb7) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Sep 7, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

Going to push as commit 708407e.
Since your change was applied there have been 56 commits pushed to the master branch:

  • 270a9d9: 8273043: [TEST_BUG] Automate NimbusJTreeSelTextColor.java
  • df05b4d: 8271923: [macos] the text color on the selected disabled tabbed pane button remains white making text unreadable
  • 2abf3b3: 8271340: Crash PhaseIdealLoop::clone_outer_loop
  • 99fb12c: 8271341: Opcode() != Op_If && Opcode() != Op_RangeCheck) || outcnt() == 2 assert failure with Test7179138_1.java
  • 041ae20: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped
  • 377b186: 8269119: C2: Avoid redundant memory barriers in Unsafe.copyMemory0 intrinsic
  • 70157c7: 8272135: jshell: Method cannot use its overloaded version
  • 5caa77b: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream
  • a522d6b: 8273376: Zero: Disable vtable/itableStub gtests
  • 3cd95a2: 8231356: Fix broken ResourceObj::operator new[] in debug builds
  • ... and 46 more: https://git.openjdk.java.net/jdk/compare/a58cf16509f3120d69fc18bd4c2c49e9ad590f73...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Sep 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

@aivanov-jdk @turbanoff Pushed as commit 708407e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the redundant_boxing_in_java.desktop branch Sep 15, 2021
@openjdk openjdk bot added the client label Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d awt client integrated swing
2 participants