Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272985: Reference discovery is confused about atomicity and degree of parallelism #5314

Conversation

@tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Aug 31, 2021

Hi all,

can I have reviews for this change that fixes some (apparent) confusion between atomicity (of the discovery in the ReferenceProcessor sense) vs. the currently selected degree of parallelism?

For all four different combinations of atomicity and parallelism the discovered link in the java.lang.ref.Reference needs to be updated differently using a different kind of access, instead of just two based on atomicity.

I'll fix the use of atomic in ReferenceProcessor in a separate CR to hopefully remove the confusion for the reader too.

Testing: tier1-5, internal perf benchmarks without regressions

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272985: Reference discovery is confused about atomicity and degree of parallelism

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5314/head:pull/5314
$ git checkout pull/5314

Update a local copy of the PR:
$ git checkout pull/5314
$ git pull https://git.openjdk.java.net/jdk pull/5314/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5314

View PR using the GUI difftool:
$ git pr show -t 5314

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5314.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 31, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 31, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label Aug 31, 2021
@tschatzl tschatzl marked this pull request as ready for review Aug 31, 2021
@openjdk openjdk bot added the rfr label Aug 31, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 31, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 3, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272985: Reference discovery is confused about atomicity and degree of parallelism

Reviewed-by: ayang, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

  • d414a88: 8273240: Dynamic test ArchiveConsistency.java should use CDSArchiveUtils
  • 23fa0dc: 8272905: Consolidate discovered lists processing
  • ff4018b: 8268148: unchecked warnings handle ? and ? extends Object differently
  • 8c37909: 8273234: extended 'for' with expression of type tvar causes the compiler to crash
  • 28ba78e: 8244675: assert(IncrementalInline || (_late_inlines.length() == 0 && !has_mh_late_inlines()))
  • d05494f: 8266239: Some duplicated javac command-line options have repeated effect
  • 93eec9a: 8272776: NullPointerException not reported
  • 7b023a3: 8273257: jshell doesn't compile a sealed hierarchy with a sealed interface and a non-sealed leaf
  • f17ee0c: 8273263: Incorrect recovery attribution of record component type when j.l.Record is unavailable
  • fa9c865: 8273112: -Xloggc: should override -verbose:gc
  • ... and 55 more: https://git.openjdk.java.net/jdk/compare/f55d5ab5177b6e08e8499abc181a320a98b28a5f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 3, 2021
Copy link

@kimbarrett kimbarrett left a comment

Looks good.

Loading

@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Sep 6, 2021

Thanks @kimbarrett @albertnetymk for your reviews.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2021

Going to push as commit fb5b144.
Since your change was applied there have been 71 commits pushed to the master branch:

  • 70ed6c5: 8272878: JEP 381 cleanup: Remove unused Solaris code in sun.font.TrueTypeGlyphMapper
  • b4e5b28: 8273221: Guard GCIdMark against nested calls
  • 4d25e6f: 8273335: compiler/blackhole tests should not run with interpreter-only VMs
  • c640fe4: 7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails
  • cec6c06: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'."
  • 14a3ac0: 8271911: replay compilations of methods which use JSR292 (easy cases)
  • d414a88: 8273240: Dynamic test ArchiveConsistency.java should use CDSArchiveUtils
  • 23fa0dc: 8272905: Consolidate discovered lists processing
  • ff4018b: 8268148: unchecked warnings handle ? and ? extends Object differently
  • 8c37909: 8273234: extended 'for' with expression of type tvar causes the compiler to crash
  • ... and 61 more: https://git.openjdk.java.net/jdk/compare/f55d5ab5177b6e08e8499abc181a320a98b28a5f...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2021

@tschatzl Pushed as commit fb5b144.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@tschatzl tschatzl deleted the submit/8272985-confused-reference-discovery branch Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants