Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302 #5315

Closed
wants to merge 1 commit into from

Conversation

xpbob
Copy link
Contributor

@xpbob xpbob commented Aug 31, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5315/head:pull/5315
$ git checkout pull/5315

Update a local copy of the PR:
$ git checkout pull/5315
$ git pull https://git.openjdk.java.net/jdk pull/5315/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5315

View PR using the GUI difftool:
$ git pr show -t 5315

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5315.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 31, 2021

👋 Welcome back xpbob! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 31, 2021

@xpbob The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review labels Aug 31, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 31, 2021

Webrevs

Copy link
Member

@DamonFool DamonFool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for fixing it.

@openjdk
Copy link

openjdk bot commented Aug 31, 2021

@xpbob This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302

Reviewed-by: jiefu, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 1996f64: 8273092: Sort classlist in JDK image
  • ba3587e: 8273144: Remove unused top level "Sample Collection Set Candidates" logging
  • 75d987a: 8262095: NPE in Flow$FlowAnalyzer.visitApply: Cannot invoke getThrownTypes because tree.meth.type is null
  • e551852: 8271225: Add floorDivExact() method to java.lang.[Strict]Math
  • e671255: 8237567: Refactor G1-specific code in shared VM_CollectForMetadataAllocation
  • 9bc7cc5: 8273033: SerialGC: remove obsolete comments
  • 841e394: 8159979: During initial mark, preparing all regions for marking may take a significant amount of time
  • 98fa533: 8273100: Improve AbstractStringBuilder.append(String) when using CompactStrings

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@DamonFool, @mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 31, 2021
@xpbob
Copy link
Contributor Author

xpbob commented Aug 31, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 31, 2021
@openjdk
Copy link

openjdk bot commented Aug 31, 2021

@xpbob
Your change (at version 9b93022) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

mrserb commented Aug 31, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 31, 2021

Going to push as commit 683e30d.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 1996f64: 8273092: Sort classlist in JDK image
  • ba3587e: 8273144: Remove unused top level "Sample Collection Set Candidates" logging
  • 75d987a: 8262095: NPE in Flow$FlowAnalyzer.visitApply: Cannot invoke getThrownTypes because tree.meth.type is null
  • e551852: 8271225: Add floorDivExact() method to java.lang.[Strict]Math
  • e671255: 8237567: Refactor G1-specific code in shared VM_CollectForMetadataAllocation
  • 9bc7cc5: 8273033: SerialGC: remove obsolete comments
  • 841e394: 8159979: During initial mark, preparing all regions for marking may take a significant amount of time
  • 98fa533: 8273100: Improve AbstractStringBuilder.append(String) when using CompactStrings

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 31, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 31, 2021
@openjdk
Copy link

openjdk bot commented Aug 31, 2021

@mrserb @xpbob Pushed as commit 683e30d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants