Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8273176: handle latest VS2019 in abstract_vm_version #5317

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Aug 31, 2021

Please review this small change.
It handles latest VS2019 versions in abstract_vm_version, e.g. 16.10.
See the _MSC_VER documentation at https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-160

Thanks, Matthias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273176: handle latest VS2019 in abstract_vm_version

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5317/head:pull/5317
$ git checkout pull/5317

Update a local copy of the PR:
$ git checkout pull/5317
$ git pull https://git.openjdk.java.net/jdk pull/5317/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5317

View PR using the GUI difftool:
$ git pr show -t 5317

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5317.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 31, 2021

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 31, 2021
@openjdk
Copy link

openjdk bot commented Aug 31, 2021

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Aug 31, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 31, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and trivial.

Thanks,
David

@openjdk
Copy link

openjdk bot commented Sep 1, 2021

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273176: handle latest VS2019 in abstract_vm_version

Reviewed-by: kevinw, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • e600fe1: 8272618: Unnecessary Attr.visitIdent.noOuterThisPath
  • 2fce7cb: 8272963: Update the java manpage markdown source
  • 18a731a: 8269770: nsk tests should start IOPipe channel before launch debuggee - Debugee.prepareDebugee
  • 9c392d0: 8273197: ProblemList 2 jtools tests due to JDK-8273187
  • 3d657eb: 8262186: Call X509KeyManager.chooseClientAlias once for all key types
  • c1e0aac: 8273186: Remove leftover comment about sparse remembered set in G1 HeapRegionRemSet
  • 683e30d: 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302
  • 1996f64: 8273092: Sort classlist in JDK image
  • ba3587e: 8273144: Remove unused top level "Sample Collection Set Candidates" logging
  • 75d987a: 8262095: NPE in Flow$FlowAnalyzer.visitApply: Cannot invoke getThrownTypes because tree.meth.type is null
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/9732fbe428c3b6a5422cc94e7295ba5482d1a7a9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 1, 2021
@MBaesken
Copy link
Member Author

MBaesken commented Sep 1, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 1, 2021

Going to push as commit 0e14bf7.
Since your change was applied there have been 16 commits pushed to the master branch:

  • f1c5e26: 8273206: jdk/jfr/event/gc/collection/TestG1ParallelPhases.java fails after JDK-8159979
  • e600fe1: 8272618: Unnecessary Attr.visitIdent.noOuterThisPath
  • 2fce7cb: 8272963: Update the java manpage markdown source
  • 18a731a: 8269770: nsk tests should start IOPipe channel before launch debuggee - Debugee.prepareDebugee
  • 9c392d0: 8273197: ProblemList 2 jtools tests due to JDK-8273187
  • 3d657eb: 8262186: Call X509KeyManager.chooseClientAlias once for all key types
  • c1e0aac: 8273186: Remove leftover comment about sparse remembered set in G1 HeapRegionRemSet
  • 683e30d: 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302
  • 1996f64: 8273092: Sort classlist in JDK image
  • ba3587e: 8273144: Remove unused top level "Sample Collection Set Candidates" logging
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/9732fbe428c3b6a5422cc94e7295ba5482d1a7a9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 1, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 1, 2021
@openjdk
Copy link

openjdk bot commented Sep 1, 2021

@MBaesken Pushed as commit 0e14bf7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for adding support for the latest MSVC++.
Lutz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants