Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273186: Remove leftover comment about sparse remembered set in G1 HeapRegionRemSet #5319

Closed

Conversation

@tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Aug 31, 2021

Hi all,

please review this trivial one-line obsolete comment about sparse remembered sets which do not exist any more.

Testing: local compilation

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273186: Remove leftover comment about sparse remembered set in G1 HeapRegionRemSet

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5319/head:pull/5319
$ git checkout pull/5319

Update a local copy of the PR:
$ git checkout pull/5319
$ git pull https://git.openjdk.java.net/jdk pull/5319/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5319

View PR using the GUI difftool:
$ git pr show -t 5319

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5319.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 31, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Aug 31, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 31, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label Aug 31, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 31, 2021

Webrevs

Loading

Copy link
Member

@albertnetymk albertnetymk left a comment

Trivial.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 31, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273186: Remove leftover comment about sparse remembered set in G1 HeapRegionRemSet

Reviewed-by: ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Aug 31, 2021
@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Aug 31, 2021

Thanks @albertnetymk

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 31, 2021

Going to push as commit c1e0aac.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 683e30d: 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302
  • 1996f64: 8273092: Sort classlist in JDK image

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Aug 31, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 31, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 31, 2021

@tschatzl Pushed as commit c1e0aac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@tschatzl tschatzl deleted the submit/8273186-remove-comment branch Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants