Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273206: jdk/jfr/event/gc/collection/TestG1ParallelPhases.java fails after JDK-8159979 #5322

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Aug 31, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273206: jdk/jfr/event/gc/collection/TestG1ParallelPhases.java fails after JDK-8159979

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5322/head:pull/5322
$ git checkout pull/5322

Update a local copy of the PR:
$ git checkout pull/5322
$ git pull https://git.openjdk.java.net/jdk pull/5322/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5322

View PR using the GUI difftool:
$ git pr show -t 5322

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5322.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 31, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 31, 2021

@DamonFool The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot rfr labels Aug 31, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 31, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Jie,

Seems fine, but please add an explanatory comment in the JBS issue and/or the PR description so that reviewers know what the problem and solution are.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273206: jdk/jfr/event/gc/collection/TestG1ParallelPhases.java fails after JDK-8159979

Reviewed-by: dholmes, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • e600fe1: 8272618: Unnecessary Attr.visitIdent.noOuterThisPath
  • 2fce7cb: 8272963: Update the java manpage markdown source
  • 18a731a: 8269770: nsk tests should start IOPipe channel before launch debuggee - Debugee.prepareDebugee

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 1, 2021
@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Sep 1, 2021

Hi Jie,

Seems fine, but please add an explanatory comment in the JBS issue and/or the PR description so that reviewers know what the problem and solution are.

Thanks,
David

Thanks @dholmes-ora .

Just too busy this morning and won't do it again.
Thanks.

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Sep 1, 2021

Thanks @albertnetymk .
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2021

Going to push as commit f1c5e26.
Since your change was applied there have been 3 commits pushed to the master branch:

  • e600fe1: 8272618: Unnecessary Attr.visitIdent.noOuterThisPath
  • 2fce7cb: 8272963: Update the java manpage markdown source
  • 18a731a: 8269770: nsk tests should start IOPipe channel before launch debuggee - Debugee.prepareDebugee

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2021

@DamonFool Pushed as commit f1c5e26.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8273206 branch Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated
3 participants