Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273217: Make ParHeapInspectTask _safepoint_check_never #5323

Closed
wants to merge 1 commit into from

Conversation

@coleenp
Copy link
Contributor

@coleenp coleenp commented Sep 1, 2021

Make lock be declared as safepoint_check_never.
Ran tier1-3 tests and test that uses this code: serviceability/dcmd/gc/ClassHistogramTest.java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273217: Make ParHeapInspectTask _safepoint_check_never

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5323/head:pull/5323
$ git checkout pull/5323

Update a local copy of the PR:
$ git checkout pull/5323
$ git pull https://git.openjdk.java.net/jdk pull/5323/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5323

View PR using the GUI difftool:
$ git pr show -t 5323

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5323.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 1, 2021

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2021

@coleenp The following labels will be automatically applied to this pull request:

  • hotspot-runtime
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 1, 2021

Webrevs

Loading

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Coleen,

The main change is fine, but the other seems unnecessary - see comment below.

Thanks,
David

Loading

src/hotspot/share/memory/heapInspection.cpp Show resolved Hide resolved
Loading
src/hotspot/share/memory/heapInspection.cpp Show resolved Hide resolved
Loading
@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2021

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273217: Make ParHeapInspectTask _safepoint_check_never

Reviewed-by: dholmes, pchilanomate

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 02822e1: 8272377: assert preconditions that are ensured when created in add_final_edges
  • a58cf16: 8272563: assert(is_double_stack() && !is_virtual()) failed: type check
  • 0e14bf7: 8273176: handle latest VS2019 in abstract_vm_version
  • f1c5e26: 8273206: jdk/jfr/event/gc/collection/TestG1ParallelPhases.java fails after JDK-8159979
  • e600fe1: 8272618: Unnecessary Attr.visitIdent.noOuterThisPath
  • 2fce7cb: 8272963: Update the java manpage markdown source
  • 18a731a: 8269770: nsk tests should start IOPipe channel before launch debuggee - Debugee.prepareDebugee
  • 9c392d0: 8273197: ProblemList 2 jtools tests due to JDK-8273187
  • 3d657eb: 8262186: Call X509KeyManager.chooseClientAlias once for all key types
  • c1e0aac: 8273186: Remove leftover comment about sparse remembered set in G1 HeapRegionRemSet

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 1, 2021
Copy link
Contributor

@pchilano pchilano left a comment

LGTM.

Thanks,
Patricio

Loading

@coleenp
Copy link
Contributor Author

@coleenp coleenp commented Sep 1, 2021

Thanks David and Patricio!
/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2021

Going to push as commit dacd197.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 02822e1: 8272377: assert preconditions that are ensured when created in add_final_edges
  • a58cf16: 8272563: assert(is_double_stack() && !is_virtual()) failed: type check
  • 0e14bf7: 8273176: handle latest VS2019 in abstract_vm_version
  • f1c5e26: 8273206: jdk/jfr/event/gc/collection/TestG1ParallelPhases.java fails after JDK-8159979
  • e600fe1: 8272618: Unnecessary Attr.visitIdent.noOuterThisPath
  • 2fce7cb: 8272963: Update the java manpage markdown source
  • 18a731a: 8269770: nsk tests should start IOPipe channel before launch debuggee - Debugee.prepareDebugee
  • 9c392d0: 8273197: ProblemList 2 jtools tests due to JDK-8273187
  • 3d657eb: 8262186: Call X509KeyManager.chooseClientAlias once for all key types
  • c1e0aac: 8273186: Remove leftover comment about sparse remembered set in G1 HeapRegionRemSet

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2021

@coleenp Pushed as commit dacd197.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@coleenp coleenp deleted the heapinspect branch Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants