Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273242: (test) Refactor to use TestNG for RuntimeTests ExecCommand tests #5335

Closed

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Sep 1, 2021

The ExecCommand test of Runtime.exec is difficult to maintain; the parallel arrays are hard to keep in sync.
This cleanup converts to use TestNG DataProviders and other improvements.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273242: (test) Refactor to use TestNG for RuntimeTests ExecCommand tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5335/head:pull/5335
$ git checkout pull/5335

Update a local copy of the PR:
$ git checkout pull/5335
$ git pull https://git.openjdk.java.net/jdk pull/5335/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5335

View PR using the GUI difftool:
$ git pr show -t 5335

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5335.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 1, 2021

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2021

@RogerRiggs The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Sep 1, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 1, 2021

Webrevs

naotoj
naotoj approved these changes Sep 7, 2021
Copy link
Member

@naotoj naotoj left a comment

LGTM.

test/jdk/java/lang/RuntimeTests/exec/ExecCommand.java Outdated Show resolved Hide resolved
@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273242: (test) Refactor to use TestNG for RuntimeTests ExecCommand tests

Reviewed-by: naoto, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 78 new commits pushed to the master branch:

  • a5e4def: 8265489: Stress test times out because of long ObjectSynchronizer::monitors_iterate(...) operation
  • 9b5991e: 8273451: Remove unreachable return in mutexLocker::wait
  • e680503: 8273185: Rename the term "atomic" in ReferenceProcessor
  • ba31eee: 8273109: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest times out
  • 4d5e1ed: 8272375: Improve phrasing of synthesized descriptions in JavaFX docs
  • 267c61a: 8273361: InfoOptsTest is failing in tier1
  • f7e9f56: 8273359: CI: ciInstanceKlass::get_canonical_holder() doesn't respect instance size
  • d7efd0e: 8273450: Fix the copyright header of SVML files
  • e5f298a: 8273329: Remove redundant null check from String.getBytes(String charsetName)
  • cb112af: 8269373: some tests in jdk/tools/launcher/ fails on localized Windows platform
  • ... and 68 more: https://git.openjdk.java.net/jdk/compare/4ee0dacecd5afc5876ea839ffbb5df962ff6cd08...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 7, 2021
Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Looks good Roger.

A couple trivial questions/suggestions below but feel free to ignore :-)

test/jdk/java/lang/RuntimeTests/exec/ExecCommand.java Outdated Show resolved Hide resolved
test/jdk/java/lang/RuntimeTests/exec/ExecCommand.java Outdated Show resolved Hide resolved
Add enum to document test modes.
naotoj
naotoj approved these changes Sep 8, 2021
@RogerRiggs
Copy link
Contributor Author

@RogerRiggs RogerRiggs commented Sep 8, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

Going to push as commit 7fd6b0b.
Since your change was applied there have been 78 commits pushed to the master branch:

  • a5e4def: 8265489: Stress test times out because of long ObjectSynchronizer::monitors_iterate(...) operation
  • 9b5991e: 8273451: Remove unreachable return in mutexLocker::wait
  • e680503: 8273185: Rename the term "atomic" in ReferenceProcessor
  • ba31eee: 8273109: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest times out
  • 4d5e1ed: 8272375: Improve phrasing of synthesized descriptions in JavaFX docs
  • 267c61a: 8273361: InfoOptsTest is failing in tier1
  • f7e9f56: 8273359: CI: ciInstanceKlass::get_canonical_holder() doesn't respect instance size
  • d7efd0e: 8273450: Fix the copyright header of SVML files
  • e5f298a: 8273329: Remove redundant null check from String.getBytes(String charsetName)
  • cb112af: 8269373: some tests in jdk/tools/launcher/ fails on localized Windows platform
  • ... and 68 more: https://git.openjdk.java.net/jdk/compare/4ee0dacecd5afc5876ea839ffbb5df962ff6cd08...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

@RogerRiggs Pushed as commit 7fd6b0b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
3 participants