Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273248: ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs #5337

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Sep 1, 2021

A trivial fix to ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273248: ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5337/head:pull/5337
$ git checkout pull/5337

Update a local copy of the PR:
$ git checkout pull/5337
$ git pull https://git.openjdk.java.net/jdk pull/5337/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5337

View PR using the GUI difftool:
$ git pr show -t 5337

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5337.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 1, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Sep 1, 2021

/label add hotspot-runtime
/label add serviceability
/label add core-libs

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Sep 1, 2021
naotoj
naotoj approved these changes Sep 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273248: ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr hotspot-runtime labels Sep 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the serviceability label Sep 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2021

@dcubed-ojdk
The serviceability label was successfully added.

@openjdk openjdk bot added the core-libs label Sep 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2021

@dcubed-ojdk
The core-libs label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 1, 2021

Webrevs

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Sep 1, 2021

@naotoj - Thanks for the review!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2021

Going to push as commit 4ee0dac.

@openjdk openjdk bot closed this Sep 1, 2021
@openjdk openjdk bot added integrated and removed ready labels Sep 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2021

@dcubed-ojdk Pushed as commit 4ee0dac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Sep 1, 2021
@dcubed-ojdk dcubed-ojdk deleted the JDK-8273248 branch Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs hotspot-runtime integrated serviceability
2 participants