Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7188098 : TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails #5338

Closed
wants to merge 3 commits into from

Conversation

lawrence-andrew
Copy link
Contributor

@lawrence-andrew lawrence-andrew commented Sep 1, 2021

  1. Testcase was failing with Parse Exception: Arguments to `manual' option not supported: yesno due to yesno

  2. After removing =yesno once again test case was failing with following exception
    ----------System.err:(15/782)----------
    java.io.IOException: Illegal seek
    at java.io.FileInputStream.skip(Native Method)
    at java.io.BufferedInputStream.skip(BufferedInputStream.java:366)
    at bug6186488.main(bug6186488.java:36)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:474)
    at com.sun.javatest.regtest.MainWrapper$MainThread.run(MainWrapper.java:96)
    at java.lang.Thread.run(Thread.java:722)

  3. If test case is run independently user has to enter y or n to make the test case pass or fail that is when user heard the sound or no. The same action was able to perform via JTREG.

  4. Rewrote the testcase . Now user can listen to sound when he press "Start Test" and press "pass" button if user hears the sound and press "fail" button when user does not hear the sound. Test UI also shows a timer that get timeout if user does not perform any action.

  5. Add try-with-resource to close the synth.

@shurymury


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5338/head:pull/5338
$ git checkout pull/5338

Update a local copy of the PR:
$ git checkout pull/5338
$ git pull https://git.openjdk.java.net/jdk pull/5338/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5338

View PR using the GUI difftool:
$ git pr show -t 5338

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5338.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 1, 2021

👋 Welcome back lawrence-andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2021

@lawrence-andrew The following label will be automatically applied to this pull request:

  • sound

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the sound label Sep 1, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 1, 2021

Webrevs

mrserb
mrserb approved these changes Sep 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 4, 2021

@lawrence-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 590 new commits pushed to the master branch:

  • cec6c06: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'."
  • 14a3ac0: 8271911: replay compilations of methods which use JSR292 (easy cases)
  • d414a88: 8273240: Dynamic test ArchiveConsistency.java should use CDSArchiveUtils
  • 23fa0dc: 8272905: Consolidate discovered lists processing
  • ff4018b: 8268148: unchecked warnings handle ? and ? extends Object differently
  • 8c37909: 8273234: extended 'for' with expression of type tvar causes the compiler to crash
  • 28ba78e: 8244675: assert(IncrementalInline || (_late_inlines.length() == 0 && !has_mh_late_inlines()))
  • d05494f: 8266239: Some duplicated javac command-line options have repeated effect
  • 93eec9a: 8272776: NullPointerException not reported
  • 7b023a3: 8273257: jshell doesn't compile a sealed hierarchy with a sealed interface and a non-sealed leaf
  • ... and 580 more: https://git.openjdk.java.net/jdk/compare/92ae6a512340485f75a12479dc1c1b8d3261bc76...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 4, 2021
@lawrence-andrew
Copy link
Contributor Author

@lawrence-andrew lawrence-andrew commented Sep 4, 2021

/integrate

@openjdk openjdk bot added the sponsor label Sep 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 4, 2021

@lawrence-andrew
Your change (at version cb6bcd3) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

@mrserb mrserb commented Sep 5, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Sep 5, 2021

Going to push as commit c640fe4.
Since your change was applied there have been 590 commits pushed to the master branch:

  • cec6c06: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'."
  • 14a3ac0: 8271911: replay compilations of methods which use JSR292 (easy cases)
  • d414a88: 8273240: Dynamic test ArchiveConsistency.java should use CDSArchiveUtils
  • 23fa0dc: 8272905: Consolidate discovered lists processing
  • ff4018b: 8268148: unchecked warnings handle ? and ? extends Object differently
  • 8c37909: 8273234: extended 'for' with expression of type tvar causes the compiler to crash
  • 28ba78e: 8244675: assert(IncrementalInline || (_late_inlines.length() == 0 && !has_mh_late_inlines()))
  • d05494f: 8266239: Some duplicated javac command-line options have repeated effect
  • 93eec9a: 8272776: NullPointerException not reported
  • 7b023a3: 8273257: jshell doesn't compile a sealed hierarchy with a sealed interface and a non-sealed leaf
  • ... and 580 more: https://git.openjdk.java.net/jdk/compare/92ae6a512340485f75a12479dc1c1b8d3261bc76...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Sep 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 5, 2021

@mrserb @lawrence-andrew Pushed as commit c640fe4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated sound
2 participants