8271602: Add Math.ceilDiv() family parallel to Math.floorDiv() family #5341

rgiulietti · 2021-09-01T20:13:38Z

This PR ideally continues #5285, which has been closed as a consequence of inadvertently removing the branch on my repo. See there for initial discussion.

Sorry for the mess.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8271602: Add Math.ceilDiv() family parallel to Math.floorDiv() family

Reviewers

Brian Burkhalter (@bplb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5341/head:pull/5341
$ git checkout pull/5341

Update a local copy of the PR:
$ git checkout pull/5341
$ git pull https://git.openjdk.java.net/jdk pull/5341/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5341

View PR using the GUI difftool:
$ git pr show -t 5341

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5341.diff

rgiulietti · 2021-09-01T20:14:32Z

/csr

bridgekeeper · 2021-09-01T20:14:43Z

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-09-01T20:16:29Z

@rgiulietti this pull request will not be integrated until the CSR request JDK-8273090 for issue JDK-8271602 has been approved.

openjdk · 2021-09-01T20:18:03Z

@rgiulietti The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-09-01T20:21:40Z

Webrevs

01: Full - Incremental (8e368361)
00: Full (7afe3cf0)

bplb · 2021-09-09T23:44:24Z

src/java.base/share/classes/java/lang/StrictMath.java

+    /**
+     * Returns the ceiling modulus of the {@code long} arguments.
+     * <p>
+     * The floor modulus is {@code r = x - (ceilDiv(x, y) * y)},


In line 1464 I think floor should be ceiling.

bplb · 2021-09-09T23:44:49Z

src/java.base/share/classes/java/lang/StrictMath.java

+     * Returns the ceiling modulus of the {@code long} arguments.
+     * <p>
+     * The floor modulus is {@code r = x - (ceilDiv(x, y) * y)},
+     * has the same sign as the divisor {@code y} or is zero, and


In line 1465 I think same should be opposite.

Just pushed the corrections.

openjdk · 2021-09-21T23:20:44Z

@rgiulietti This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271602: Add Math.ceilDiv() family parallel to Math.floorDiv() family

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 243 new commits pushed to the master branch:

d9872ba: 8273590: Move helper classes in G1 post evacuation sub tasks to cpp files
688b3fe: 8274070: Rectify problemlist platform for failing test on macos12
eeaf43b: 8274114: ProblemList serviceability/sa/TestJhsdbJstackMixed.java on linux-aarch64 in -Xcomp mode
517405e: 8273965: some testlibrary_tests/ir_framework tests fail when c1 disabled
11cddd3: 8272114: Unused _last_state in osThread_windows
cbe57e8: 8273684: Replace usages of java.util.Stack with ArrayDeque
a72c8aa: 8273921: Refactor NSK/JDI tests to create thread using factory
161fdb4: 8273935: (zipfs) Files.getFileAttributeView() throws UOE instead of returning null when view not supported
0fc47e9: 8266666: Implementation for snippets
6d91a3e: 8269039: Disable SHA-1 Signed JARs
... and 233 more: https://git.openjdk.java.net/jdk/compare/9689f615206e96f17ffc1fe7a8efeee0a90c904b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@bplb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

rgiulietti · 2021-09-22T08:03:48Z

/integrate

openjdk · 2021-09-22T08:05:25Z

@rgiulietti
Your change (at version 8e36836) is now ready to be sponsored by a Committer.

bplb · 2021-09-22T16:15:00Z

/sponsor

openjdk · 2021-09-22T16:16:25Z

Going to push as commit da38ced.
Since your change was applied there have been 256 commits pushed to the master branch:

d39aad9: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()
c9de806: 8274039: codestrings gtest fails when hsdis is present
33df388: 8274003: ProcessHandleImpl.Info toString has an if check which is always true
0a36163: 8272600: (test) Use native "sleep" in Basic.java
c6df3c9: 8274071: Clean up java.lang.ref comments and documentation
71788c6: 8271287: jdk/jshell/CommandCompletionTest.java fails with "lists don't have the same size expected"
ba7d550: 8270139: jshell InternalError crash for import of @repeatable followed by unresolved ref
aefd4ac: 8258734: jdk/jfr/event/oldobject/TestClassLoaderLeak.java failed with "RuntimeException: Could not find class leak"
d245a8c: 8274069: Clean up g1ParScanThreadState a bit
3f73ca7: 8274068: Rename G1ScanInYoungSetter to G1SkipCardEnqueueSetter
... and 246 more: https://git.openjdk.java.net/jdk/compare/9689f615206e96f17ffc1fe7a8efeee0a90c904b...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-09-22T16:16:43Z

@bplb @rgiulietti Pushed as commit da38ced.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8271602: Add Math.ceilDiv() family parallel to Math.floorDiv() family

7afe3cf

openjdk bot added rfr Pull request is ready for review csr Pull request needs approved CSR before integration labels Sep 1, 2021

openjdk bot added the core-libs core-libs-dev@openjdk.org label Sep 1, 2021

bplb reviewed Sep 9, 2021

View reviewed changes

8271602: Add Math.ceilDiv() family parallel to Math.floorDiv() family

8e36836

bplb approved these changes Sep 11, 2021

View reviewed changes

openjdk bot removed the csr Pull request needs approved CSR before integration label Sep 21, 2021

openjdk bot added the ready Pull request is ready to be integrated label Sep 21, 2021

openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 22, 2021

openjdk bot closed this Sep 22, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 22, 2021

rgiulietti deleted the JDK-8271602 branch September 22, 2021 19:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8271602: Add Math.ceilDiv() family parallel to Math.floorDiv() family #5341

8271602: Add Math.ceilDiv() family parallel to Math.floorDiv() family #5341

Uh oh!

rgiulietti commented Sep 1, 2021 •

edited by openjdk bot

Loading

Uh oh!

rgiulietti commented Sep 1, 2021

Uh oh!

bridgekeeper bot commented Sep 1, 2021

Uh oh!

openjdk bot commented Sep 1, 2021

Uh oh!

openjdk bot commented Sep 1, 2021

Uh oh!

mlbridge bot commented Sep 1, 2021 •

edited

Loading

Uh oh!

bplb Sep 9, 2021

Uh oh!

bplb Sep 9, 2021

Uh oh!

rgiulietti Sep 10, 2021

Uh oh!

openjdk bot commented Sep 21, 2021 •

edited

Loading

Uh oh!

rgiulietti commented Sep 22, 2021

Uh oh!

openjdk bot commented Sep 22, 2021

Uh oh!

bplb commented Sep 22, 2021

Uh oh!

openjdk bot commented Sep 22, 2021

Uh oh!

openjdk bot commented Sep 22, 2021

Uh oh!

Uh oh!

8271602: Add Math.ceilDiv() family parallel to Math.floorDiv() family #5341

8271602: Add Math.ceilDiv() family parallel to Math.floorDiv() family #5341

Uh oh!

Conversation

rgiulietti commented Sep 1, 2021 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

rgiulietti commented Sep 1, 2021

Uh oh!

bridgekeeper bot commented Sep 1, 2021

Uh oh!

openjdk bot commented Sep 1, 2021

Uh oh!

openjdk bot commented Sep 1, 2021

Uh oh!

mlbridge bot commented Sep 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

bplb Sep 9, 2021

Choose a reason for hiding this comment

Uh oh!

bplb Sep 9, 2021

Choose a reason for hiding this comment

Uh oh!

rgiulietti Sep 10, 2021

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Sep 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rgiulietti commented Sep 22, 2021

Uh oh!

openjdk bot commented Sep 22, 2021

Uh oh!

bplb commented Sep 22, 2021

Uh oh!

openjdk bot commented Sep 22, 2021

Uh oh!

openjdk bot commented Sep 22, 2021

Uh oh!

Uh oh!

rgiulietti commented Sep 1, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Sep 1, 2021 •

edited

Loading

openjdk bot commented Sep 21, 2021 •

edited

Loading