New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8273256: runtime/cds/appcds/TestEpsilonGCWithCDS.java fails due to Unrecognized VM option 'ObjectAlignmentInBytes=64' on x86_32 #5345
Conversation
…recognized VM option 'ObjectAlignmentInBytes=64' on x86_32
|
@DamonFool The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a reasonable way to fix this.
Thanks,
David
@DamonFool This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for fixing this.
Thanks @dholmes-ora and @iklam . |
Going to push as commit a9a83b2. |
@DamonFool Pushed as commit a9a83b2. |
Hi all,
It fails on x86_32 since
ObjectAlignmentInBytes
is not a VM option.Let's fix it.
Thanks.
Best regards,
Jie
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5345/head:pull/5345
$ git checkout pull/5345
Update a local copy of the PR:
$ git checkout pull/5345
$ git pull https://git.openjdk.java.net/jdk pull/5345/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5345
View PR using the GUI difftool:
$ git pr show -t 5345
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5345.diff