Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254112: javax/swing/plaf/basic/BasicComboPopup/JComboBoxPopupLocation/JComboBoxPopupLocation.java fails on windows #535

Closed
wants to merge 2 commits into from

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Oct 7, 2020

Please review a test issue where the test was seen to be failing on windows mach5 system in hidpi mode.
I have ran the test locally with different scale factors without reproducing the issue. Also, mach5 job running this test for several iterations works ok.
So, proposing to remove the test from ProblemList.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (3/3 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8254112: javax/swing/plaf/basic/BasicComboPopup/JComboBoxPopupLocation/JComboBoxPopupLocation.java fails on windows

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/535/head:pull/535
$ git checkout pull/535

…n/JComboBoxPopupLocation.java fails on windows
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 7, 2020

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Oct 7, 2020

mach5 job link is in JBS

@openjdk openjdk bot added the rfr label Oct 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2020

@prsadhuk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Oct 7, 2020

/label add swing

@openjdk openjdk bot added the swing label Oct 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2020

@prsadhuk
The swing label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 7, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2020

@prsadhuk this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout test-failure-fix2
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the merge-conflict label Oct 7, 2020
trebari
trebari approved these changes Oct 9, 2020
@pankaj-bansal
Copy link

@pankaj-bansal pankaj-bansal commented Oct 9, 2020

Hello Prasanta,

Should not we try to find what has changed that test was failing few days back and is passing now. Is it sure that it will not fail again like mentioned in https://bugs.openjdk.java.net/browse/JDK-8238720, specially when nothing is really being changed here. It can be an intermittent failure and may fail again even though passing in mach5 job you have run.

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Oct 9, 2020

There might be some lab issue on that day which caused it to fail. There is no mach5 job listed in JDK-8238720 for this test for me to investigate. So,whatever is in my hand I am trying. I have tried to run several iterations and it passed in mach5. Needless to say it is not reproducible locally.

@pankaj-bansal
Copy link

@pankaj-bansal pankaj-bansal commented Oct 9, 2020

The bug description in JDK-8238720 says that tests are failing repeatedly on Windows hi-dpi. So if Phil has filled a bug with these tests, they must have failed few times. So finding link to mach5 job should be possible. Most of the intermittent failures are not reproducible locally, so that should not really counts here. Anyway, if you think it is all that can be done here, please go ahead with the exiting reviews or when someone else reviews.

Thanks,
Pankaj

mrserb
mrserb approved these changes Oct 23, 2020
Copy link
Member

@mrserb mrserb left a comment

Let's see how it is going on

@openjdk
Copy link

@openjdk openjdk bot commented Oct 23, 2020

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254112: javax/swing/plaf/basic/BasicComboPopup/JComboBoxPopupLocation/JComboBoxPopupLocation.java fails on windows

Reviewed-by: trebari, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 275 new commits pushed to the master branch:

  • d8d9197: 8242559: Clean the "libawt_xawt" library from code for headless mode
  • ff5f226: 8255086: Update the root locale display names
  • 8afdcae: 8255031: Update java/util/prefs/AddNodeChangeListener.java to report more failure info
  • 0aa3c92: 8255262: Remove use of legacy custom @SPEC tag
  • a0b687b: 8254854: [cgroups v1] Metric limits not properly detected on some join controller combinations
  • f279ddf: 8248411: [aarch64] Insufficient error handling when CodeBuffer is exhausted
  • 4634dbe: 8223312: Utilize handshakes instead of is_thread_fully_suspended
  • cc50c8d: 8255196: Remove unused G1FullGCCompactionPoint::merge()
  • ae72b52: 8255047: Add HotSpot UseDebuggerErgo flags
  • 211bb62: 8255124: KeepAliveStreamCleaner may crash with java.lang.IllegalMonitorStateException: current thread is not owner
  • ... and 265 more: https://git.openjdk.java.net/jdk/compare/9543d7607bcb917811ef49c568c05459aedcd297...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 23, 2020
@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Oct 25, 2020

/integrate

@openjdk openjdk bot closed this Oct 25, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 25, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 25, 2020

@prsadhuk Since your change was applied there have been 298 commits pushed to the master branch:

  • 69b0172: 8199074: Test javax/swing/DataTransfer/8059739/bug8059739.java is unstable
  • 6545e19: 8255078: sun/net/ftp/imp/FtpClient$MLSxParser uses wrong datetime format
  • 3f6abd2: 8255330: gtest/MetaspaceGtests.java fail on 32-bit platforms
  • cf821b0: 8232024: Don't pollute log output with multiple errors of the same type
  • 185c8bc: 8255338: CodeSections are never frozen
  • cc86113: 8255271: Avoid generating duplicate interpreter entries for subword types
  • 5ec1b80: 8255287: aarch64: fix SVE patterns for vector shift count
  • 12daf2b: 8255340: [s390] build failure after JDK-8255208
  • 9007bc2: 8255129: [PPC64, s390] Check vector_size_supported and add VectorReinterpret node
  • df79257: 8255274: [PPC64, s390] wrong StringLatin1.indexOf version matched
  • ... and 288 more: https://git.openjdk.java.net/jdk/compare/9543d7607bcb917811ef49c568c05459aedcd297...master

Your commit was automatically rebased without conflicts.

Pushed as commit 1a94ebc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the test-failure-fix2 branch Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants