8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped

[fguallini]

This trivial change fixes the case 2 in test sun/security/pkcs11/rsa/TestP11KeyFactoryGetRSAKeySpec, the method testKeySpec is expecting a class object of type KeySpec as second argument in order to be reusable for multiple test scenarios, but then instead of using that argument the RSAPrivateKeySpec.class is hardcoded:

private static void testKeySpec(KeyFactory factory, PrivateKey key, Class<? extends KeySpec> specClass) throws Exception {
        try {
            KeySpec spec = factory.getKeySpec(key, RSAPrivateKeySpec.class);

it should be:

KeySpec spec = factory.getKeySpec(key, specClass);

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)
• Rajan Halade (@rhalade - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5351/head:pull/5351
$ git checkout pull/5351

Update a local copy of the PR:
$ git checkout pull/5351
$ git pull https://git.openjdk.java.net/jdk pull/5351/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5351

View PR using the GUI difftool:
$ git pr show -t 5351

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5351.diff

[bridgekeeper]

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fguallini The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (acaadf9e)

[openjdk]

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped

Reviewed-by: mullan, rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

• 377b186: 8269119: C2: Avoid redundant memory barriers in Unsafe.copyMemory0 intrinsic
• 70157c7: 8272135: jshell: Method cannot use its overloaded version
• 5caa77b: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream
• a522d6b: 8273376: Zero: Disable vtable/itableStub gtests
• 3cd95a2: 8231356: Fix broken ResourceObj::operator new[] in debug builds
• 81c719b: 8273333: Zero should warn about unimplemented -XX:+LogTouchedMethods
• 649c22c: 8270832: Aarch64: Update algorithm annotations for MacroAssembler::fill_words
• eb22181: 8273386: Remove duplicated code in G1DCQS::abandon_completed_buffers
• fc546d6: 8273378: Shenandoah: Remove the remaining uses of os::is_MP
• 7bd4f49: 8264207: CodeStrings does not honour fixed address assumption.
• ... and 55 more: https://git.openjdk.java.net/jdk/compare/e67125512f585c8efad2e7685b9bc409c96563d7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@seanjmullan, @rhalade) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[fguallini]

/integrate

[openjdk]

@fguallini
Your change (at version acaadf9) is now ready to be sponsored by a Committer.

[rhalade]

/sponsor

[openjdk]

Going to push as commit 041ae20.
Since your change was applied there have been 65 commits pushed to the master branch:

• 377b186: 8269119: C2: Avoid redundant memory barriers in Unsafe.copyMemory0 intrinsic
• 70157c7: 8272135: jshell: Method cannot use its overloaded version
• 5caa77b: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream
• a522d6b: 8273376: Zero: Disable vtable/itableStub gtests
• 3cd95a2: 8231356: Fix broken ResourceObj::operator new[] in debug builds
• 81c719b: 8273333: Zero should warn about unimplemented -XX:+LogTouchedMethods
• 649c22c: 8270832: Aarch64: Update algorithm annotations for MacroAssembler::fill_words
• eb22181: 8273386: Remove duplicated code in G1DCQS::abandon_completed_buffers
• fc546d6: 8273378: Shenandoah: Remove the remaining uses of os::is_MP
• 7bd4f49: 8264207: CodeStrings does not honour fixed address assumption.
• ... and 55 more: https://git.openjdk.java.net/jdk/compare/e67125512f585c8efad2e7685b9bc409c96563d7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rhalade @fguallini Pushed as commit 041ae20.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.