Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273259: Character.getName doesn't follow Unicode spec for ideographs #5354

Closed
wants to merge 4 commits into from

Conversation

@naotoj
Copy link
Member

@naotoj naotoj commented Sep 2, 2021

Simple spec clarification. A CSR has also been drafted (https://bugs.openjdk.java.net/browse/JDK-8273296).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273259: Character.getName doesn't follow Unicode spec for ideographs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5354/head:pull/5354
$ git checkout pull/5354

Update a local copy of the PR:
$ git checkout pull/5354
$ git pull https://git.openjdk.java.net/jdk pull/5354/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5354

View PR using the GUI difftool:
$ git pr show -t 5354

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5354.diff

@naotoj
Copy link
Member Author

@naotoj naotoj commented Sep 2, 2021

/csr

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 2, 2021

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 2, 2021

@naotoj this pull request will not be integrated until the CSR request JDK-8273296 for issue JDK-8273259 has been approved.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 2, 2021

@naotoj The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 2, 2021

Webrevs

Loading

bplb
bplb approved these changes Sep 2, 2021
Copy link
Member

@irisclark irisclark left a comment

Associated CSR also "Reviewed".

Loading

@openjdk openjdk bot removed the csr label Sep 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273259: Character.getName doesn't follow Unicode spec for ideographs

Reviewed-by: bpb, lancea, iris, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • 922e86f: 8273522: Rename test property vm.cds.archived.java.heap to vm.cds.write.archived.java.heap
  • f42b927: 8273609: Fix trivial doc typos in the compiler area
  • e4cd209: 8273611: Remove unused ProfilePrint_lock
  • f690a01: 8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT
  • 5e1df2c: 8273162: AbstractSplittableWithBrineGenerator does not create a random salt
  • d4177a9: 8273351: bad tag in jdk.random module-info.java
  • ec9d1be: 8273194: Document the two possible cases when Lookup::ensureInitialized returns
  • 81d2ace: 8273369: Computing micros between two instants unexpectedly overflows for some cases
  • efe3ed1: 8273358: macOS Monterey does not have the font Times needed by Serif
  • e58c12e: 8273512: Fix the copyright header of x86 macroAssembler files
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/54dee132d1a149165e7478b29b740d086c18c424...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 10, 2021
@naotoj
Copy link
Member Author

@naotoj naotoj commented Sep 13, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

Going to push as commit 4cfa230.
Since your change was applied there have been 30 commits pushed to the master branch:

  • f9b2507: 8271834: TestStringDeduplicationAgeThreshold intermittent failures on Shenandoah
  • 261cb44: 8273629: compiler/uncommontrap/TestDeoptOOM.java fails with release VMs
  • b0d0497: 8273584: TypeElement.getSuperclass crashes for a record TypeElement when j.l.Record is not available
  • 4efcd20: 8273478: [macos11] JTabbedPane selected and pressed tab is not legible
  • a73c06d: 8273021: C2: Improve Add and Xor ideal optimizations
  • 9f86082: 8273610: LogTestFixture::restore_config() should not restore options
  • 2ee1f96: 8273484: Cleanup unnecessary null comparison before instanceof check in java.naming
  • f189dff: 8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian
  • 922e86f: 8273522: Rename test property vm.cds.archived.java.heap to vm.cds.write.archived.java.heap
  • f42b927: 8273609: Fix trivial doc typos in the compiler area
  • ... and 20 more: https://git.openjdk.java.net/jdk/compare/54dee132d1a149165e7478b29b740d086c18c424...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

@naotoj Pushed as commit 4cfa230.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants