-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8273314: Add tier4 test groups #5357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
assuming the goal of tier4 is to catch the rest of the tests, I don't think we should exclude -- Igor |
Apart from practicality of using |
it looks like the results above do not include the headful tests did you filter them out?
|
to some extent. I agree that -- Igor |
Hi Aleksey, This seems rather arbitrary and subjective to me. The tier 1-3 groupings were driven by existing tier 1-3 notions. But here the definition of tier 4 as "all the rest except ..." is not really a well-defined meaning for tier 4. I don't see that it adds any value. Perhaps there is a need for a group that is "everything except tier 1, tier 2, tier 3, applications, ..." but I wouldn't call that tier 4. Cheers, |
@iignatev: OK, I reinstated Please see new commit. As |
Then you probably need to skip "printer" tests as well. BTW it will be really good somehow to execute headless tests in tier4 concurrently, and run the headful tests in tier5 sequentially. |
Mailing list message from David Holmes on hotspot-dev: On 7/09/2021 1:17 am, Aleksey Shipilev wrote:
The difference is that your previous work just consolidated the existing David |
@dholmes-ora , although I fully agree that this might lead to some misunderstanding b/w Oracle and non-Oracle folks, I don't see how it's different from the previous patch, which introduced Thanks, |
Mailing list message from David Holmes on hotspot-dev: On 7/09/2021 2:20 pm, Igor Ignatyev wrote:
Because hotspot:tier2 and hotspot:tier3 simply grouped existing +tier2 = \ but that is not the case for tier4.
We can discuss Oracle's tier definitions privately - I don't see any Thanks, |
Once again, the disconnect between Oracle and OpenJDK test definitions seems to be the problem for Oracle's side. Rectifying that disconnect might fall under the scope of this PR, but I have to point out that it is a courtesy of upstream open-source project to care about proprietary downstream definitions. More to the point: since Tell me what you want me to do here. |
Hi Aleksey, I've discussed this with Igor and while I don't agree with the rationale I won't "block it". Cheers, |
Progress: |
All right, I am convinced that current patch is as good as it gets. GUI tests still do not run well with default parallelism, but I see no reason to block this integration before that is resolved. Either run @iignatev, @mrserb, @dholmes-ora -- are you good with this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is fine to run headful and headless tests separately.
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I abstain - you have your reviews. Cheers, |
All right, there goes. /integrate |
Going to push as commit 1f8af52.
Your commit was automatically rebased without conflicts. |
During the review of JDK-8272914 that added hotspot:tier{2,3} groups, @iignatev suggested to create tier4 groups that capture all tests not in tiers{1,2,3}.
Caveats:
applications
fromhotspot:tier4
, because they require test dependencies (e.g. jcstress).jdk:tier4
only runs well withJTREG_KEYWORDS=\!headful
or reduced concurrency withTEST_JOBS=1
, because headful tests cannot run in parallelSample run with
JTREG_KEYWORDS=\!headful
:There are interesting test failures on my machine, which I would address separately.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5357/head:pull/5357
$ git checkout pull/5357
Update a local copy of the PR:
$ git checkout pull/5357
$ git pull https://git.openjdk.java.net/jdk pull/5357/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5357
View PR using the GUI difftool:
$ git pr show -t 5357
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5357.diff