8273318: Some containers/docker/TestJFREvents.java configs are running out of memory

[shipilev]

$ CONF=linux-x86_64-server-fastdebug make run-test TEST=containers/docker/TestJFREvents.java

STDERR:
 stdout: [];
 stderr: [WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap.
]
 exitValue = 137

java.lang.RuntimeException: Expected to get exit value of [0]

at jdk.test.lib.process.OutputAnalyzer.shouldHaveExitValue(OutputAnalyzer.java:489)
at TestJFREvents.testContainerInfo(TestJFREvents.java:110)
at TestJFREvents.containerInfoTestCase(TestJFREvents.java:89)
at TestJFREvents.main(TestJFREvents.java:74)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:312)
at java.base/java.lang.Thread.run(Thread.java:833)

exitValue = 137 suggests the container was killed by OOM killer. The failing configuration is with 64m, and it is apparently too low.

Additional testing:

• Affected test now passes (5 runs out of 5 tries)
• containers/docker tests pass

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8273318: Some containers/docker/TestJFREvents.java configs are running out of memory

Reviewers

• Nick Gasson (@nick-arm - Reviewer)
• Severin Gehwolf (@jerboaa - Reviewer)
• Mikhailo Seledtsov (@mseledts - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5359/head:pull/5359
$ git checkout pull/5359

Update a local copy of the PR:
$ git checkout pull/5359
$ git pull https://git.openjdk.java.net/jdk pull/5359/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5359

View PR using the GUI difftool:
$ git pr show -t 5359

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5359.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5e638f0f)

[nick-arm]

I've also seen this failure on some AArch64 machines and this patch fixes it for me too.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273318: Some containers/docker/TestJFREvents.java configs are running out of memory

Reviewed-by: ngasson, sgehwolf, mseledtsov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

• 708407e: 8273168: Remove superfluous use of boxing in java.desktop
• 270a9d9: 8273043: [TEST_BUG] Automate NimbusJTreeSelTextColor.java
• df05b4d: 8271923: [macos] the text color on the selected disabled tabbed pane button remains white making text unreadable
• 2abf3b3: 8271340: Crash PhaseIdealLoop::clone_outer_loop
• 99fb12c: 8271341: Opcode() != Op_If && Opcode() != Op_RangeCheck) || outcnt() == 2 assert failure with Test7179138_1.java
• 041ae20: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped
• 377b186: 8269119: C2: Avoid redundant memory barriers in Unsafe.copyMemory0 intrinsic
• 70157c7: 8272135: jshell: Method cannot use its overloaded version
• 5caa77b: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream
• a522d6b: 8273376: Zero: Disable vtable/itableStub gtests
• ... and 30 more: https://git.openjdk.java.net/jdk/compare/aaa6f696b06b335f81efccf0966612b086dd2e73...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Thanks for review, @nick-arm. I wonder if @mseledts wants to take look as well?

[jerboaa]

LGTM

[mseledts]

Changes look good to me.

[shipilev]

Thanks!

/integrate

[openjdk]

Going to push as commit 7d24a33.
Since your change was applied there have been 45 commits pushed to the master branch:

• 1513dc7: 8271603: Unnecessary Vector usage in java.desktop
• ea4907a: 8273047: test jfr/api/consumer/TestRecordedFrame.java timing out
• 4eacdb3: 8273104: Refactoring option parser for UL
• 8884d2f: 8273462: ProblemList vmTestbase/vm/mlvm/anonloader/stress/oome/heap/Test.java in -Xcomp mode
• d6d6c06: 8273246: Amend the test java/nio/channels/DatagramChannel/ManySourcesAndTargets.java to execute in othervm mode
• 708407e: 8273168: Remove superfluous use of boxing in java.desktop
• 270a9d9: 8273043: [TEST_BUG] Automate NimbusJTreeSelTextColor.java
• df05b4d: 8271923: [macos] the text color on the selected disabled tabbed pane button remains white making text unreadable
• 2abf3b3: 8271340: Crash PhaseIdealLoop::clone_outer_loop
• 99fb12c: 8271341: Opcode() != Op_If && Opcode() != Op_RangeCheck) || outcnt() == 2 assert failure with Test7179138_1.java
• ... and 35 more: https://git.openjdk.java.net/jdk/compare/aaa6f696b06b335f81efccf0966612b086dd2e73...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 7d24a33.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.