Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273335: compiler/blackhole tests should not run with interpreter-only VMs #5365

Closed
wants to merge 1 commit into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Sep 3, 2021

This affects Zero, as it runs these tests expecting CompilerCommands to work. Which are obviously missing since there are no compilers configured. Since JDK-8255718, Zero knows it runs in interpreter-only mode, so we can just leverage that.

Additional testing:

  • compiler/blackhole tests are skipped with Zero
  • compiler/blackhole tests still run with Server

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273335: compiler/blackhole tests should not run with interpreter-only VMs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5365/head:pull/5365
$ git checkout pull/5365

Update a local copy of the PR:
$ git checkout pull/5365
$ git pull https://git.openjdk.java.net/jdk pull/5365/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5365

View PR using the GUI difftool:
$ git pr show -t 5365

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5365.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 3, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 3, 2021

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 3, 2021

Webrevs

Loading

Copy link
Contributor

@vnkozlov vnkozlov left a comment

trivial.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 3, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273335: compiler/blackhole tests should not run with interpreter-only VMs

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • ff4018b: 8268148: unchecked warnings handle ? and ? extends Object differently
  • 8c37909: 8273234: extended 'for' with expression of type tvar causes the compiler to crash
  • 28ba78e: 8244675: assert(IncrementalInline || (_late_inlines.length() == 0 && !has_mh_late_inlines()))
  • d05494f: 8266239: Some duplicated javac command-line options have repeated effect
  • 93eec9a: 8272776: NullPointerException not reported
  • 7b023a3: 8273257: jshell doesn't compile a sealed hierarchy with a sealed interface and a non-sealed leaf
  • f17ee0c: 8273263: Incorrect recovery attribution of record component type when j.l.Record is unavailable
  • fa9c865: 8273112: -Xloggc: should override -verbose:gc
  • dd87181: 8214761: Bug in parallel Kahan summation implementation
  • 7fff22a: 8272805: Avoid looking up standard charsets
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/aaa6f696b06b335f81efccf0966612b086dd2e73...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 3, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Sep 6, 2021

Thank you!

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2021

Going to push as commit 4d25e6f.
Since your change was applied there have been 17 commits pushed to the master branch:

  • c640fe4: 7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails
  • cec6c06: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'."
  • 14a3ac0: 8271911: replay compilations of methods which use JSR292 (easy cases)
  • d414a88: 8273240: Dynamic test ArchiveConsistency.java should use CDSArchiveUtils
  • 23fa0dc: 8272905: Consolidate discovered lists processing
  • ff4018b: 8268148: unchecked warnings handle ? and ? extends Object differently
  • 8c37909: 8273234: extended 'for' with expression of type tvar causes the compiler to crash
  • 28ba78e: 8244675: assert(IncrementalInline || (_late_inlines.length() == 0 && !has_mh_late_inlines()))
  • d05494f: 8266239: Some duplicated javac command-line options have repeated effect
  • 93eec9a: 8272776: NullPointerException not reported
  • ... and 7 more: https://git.openjdk.java.net/jdk/compare/aaa6f696b06b335f81efccf0966612b086dd2e73...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2021

@shipilev Pushed as commit 4d25e6f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@shipilev shipilev deleted the JDK-8273335-bh-no-Xint branch Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants