Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8273246 Amend the test java/nio/channels/DatagramChannel/ManySourcesAndTargets.java to execute in othervm mode #5366

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -120,7 +120,7 @@ files.app=lsof
net.netstat.app=netstat
net.netstat.av.args=-av
net.netstat.aL.args=-aL
net.netstat.m.args=-m
net.netstat.m.args=-mm
net.netstat.s.args=-s
net.ifconfig.app=ifconfig
net.ifconfig.args=-a
@@ -25,7 +25,7 @@
* @bug 8234805 8235193
* @summary Test DatagramChannel send/receive and that receive returns the expected
* sender address
* @run main ManySourcesAndTargets
* @run main/othervm ManySourcesAndTargets
Copy link
Contributor

@AlanBateman AlanBateman Sep 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks okay. Do you mind change L143 to use sender.send rather than reader.send while you are there? That will avoid at least some questions while trying to track down the underlying issue and will ensure that the test is printing out the actual sender address.

Copy link
Author

@msheppar msheppar Sep 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I can do that ... the suggested change is currently part of a set of changes for JDK-8264385, but no problem to add it here now for this change set

* @run main/othervm -Djava.net.preferIPv4Stack=true ManySourcesAndTargets
*/

@@ -170,4 +170,4 @@ private static Optional<NetworkInterface> networkInterface(InetAddress ia) {
return Optional.empty();
}
}
}
}