Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8195809: [TESTBUG] jps and jcmd -l support for containers is not tested #5368

Closed

Conversation

mseledts
Copy link
Member

@mseledts mseledts commented Sep 4, 2021

Please review this addition of new testing:

  • new test for sending jcmd commands across container boundaries
  • updated existing sidecar test, enabling jcmd test case

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8195809: [TESTBUG] jps and jcmd -l support for containers is not tested

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5368/head:pull/5368
$ git checkout pull/5368

Update a local copy of the PR:
$ git checkout pull/5368
$ git pull https://git.openjdk.java.net/jdk pull/5368/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5368

View PR using the GUI difftool:
$ git pr show -t 5368

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5368.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 4, 2021

👋 Welcome back mseledtsov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 4, 2021
@openjdk
Copy link

openjdk bot commented Sep 4, 2021

@mseledts The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Sep 4, 2021
@mseledts
Copy link
Member Author

mseledts commented Sep 4, 2021

@hseigel and Kevin Walls, please review when you have a chance

@mlbridge
Copy link

mlbridge bot commented Sep 4, 2021

Webrevs

}


// Run "jcmd -l" in a sidecar container, find the target process.
Copy link
Member

@hseigel hseigel Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 'jcmd -l' is not run in a sidecar, this comment is incorrect.

Copy link
Member Author

@mseledts mseledts Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I will update the comment.

Copy link
Member

@hseigel hseigel left a comment

The changes look good! Thanks for doing this.
Harold

@openjdk
Copy link

openjdk bot commented Sep 10, 2021

@mseledts This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8195809: [TESTBUG] jps and jcmd -l support for containers is not tested

Reviewed-by: hseigel, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 132 new commits pushed to the master branch:

  • f189dff: 8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian
  • 922e86f: 8273522: Rename test property vm.cds.archived.java.heap to vm.cds.write.archived.java.heap
  • f42b927: 8273609: Fix trivial doc typos in the compiler area
  • e4cd209: 8273611: Remove unused ProfilePrint_lock
  • f690a01: 8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT
  • 5e1df2c: 8273162: AbstractSplittableWithBrineGenerator does not create a random salt
  • d4177a9: 8273351: bad tag in jdk.random module-info.java
  • ec9d1be: 8273194: Document the two possible cases when Lookup::ensureInitialized returns
  • 81d2ace: 8273369: Computing micros between two instants unexpectedly overflows for some cases
  • efe3ed1: 8273358: macOS Monterey does not have the font Times needed by Serif
  • ... and 122 more: https://git.openjdk.java.net/jdk/compare/9c392d008a5a34cdc2ed6339a63f1a0d06efe619...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 10, 2021
Copy link

@kevinjwalls kevinjwalls left a comment

Yes looks good. I've run the tests and both running OK and passing.

@mseledts
Copy link
Member Author

mseledts commented Sep 13, 2021

Harold, Kevin, thank you for review.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 13, 2021

Going to push as commit 7c26ddb.
Since your change was applied there have been 140 commits pushed to the master branch:

  • 4cfa230: 8273259: Character.getName doesn't follow Unicode spec for ideographs
  • f9b2507: 8271834: TestStringDeduplicationAgeThreshold intermittent failures on Shenandoah
  • 261cb44: 8273629: compiler/uncommontrap/TestDeoptOOM.java fails with release VMs
  • b0d0497: 8273584: TypeElement.getSuperclass crashes for a record TypeElement when j.l.Record is not available
  • 4efcd20: 8273478: [macos11] JTabbedPane selected and pressed tab is not legible
  • a73c06d: 8273021: C2: Improve Add and Xor ideal optimizations
  • 9f86082: 8273610: LogTestFixture::restore_config() should not restore options
  • 2ee1f96: 8273484: Cleanup unnecessary null comparison before instanceof check in java.naming
  • f189dff: 8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian
  • 922e86f: 8273522: Rename test property vm.cds.archived.java.heap to vm.cds.write.archived.java.heap
  • ... and 130 more: https://git.openjdk.java.net/jdk/compare/9c392d008a5a34cdc2ed6339a63f1a0d06efe619...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 13, 2021
@openjdk
Copy link

openjdk bot commented Sep 13, 2021

@mseledts Pushed as commit 7c26ddb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
3 participants