New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8273376: Zero: Disable vtable/itableStub gtests #5377
Conversation
|
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
The copyright year also needs to be updated.
Thanks.
@shipilev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 22 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good and trivial
Thanks for reviews! /integrate |
Going to push as commit a522d6b.
Your commit was automatically rebased without conflicts. |
Simple test bug fix.
Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5377/head:pull/5377
$ git checkout pull/5377
Update a local copy of the PR:
$ git checkout pull/5377
$ git pull https://git.openjdk.java.net/jdk pull/5377/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5377
View PR using the GUI difftool:
$ git pr show -t 5377
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5377.diff