8273376: Zero: Disable vtable/itableStub gtests#5377
8273376: Zero: Disable vtable/itableStub gtests#5377shipilev wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
Webrevs
|
DamonFool
left a comment
There was a problem hiding this comment.
Looks fine to me.
The copyright year also needs to be updated.
Thanks.
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 22 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Thanks for reviews! /integrate |
|
Going to push as commit a522d6b.
Your commit was automatically rebased without conflicts. |
Simple test bug fix.
Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5377/head:pull/5377$ git checkout pull/5377Update a local copy of the PR:
$ git checkout pull/5377$ git pull https://git.openjdk.java.net/jdk pull/5377/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5377View PR using the GUI difftool:
$ git pr show -t 5377Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5377.diff