Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273386: Remove duplicated code in G1DCQS::abandon_completed_buffers #5382

Closed
wants to merge 1 commit into from

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Sep 6, 2021

Please review this small change to remove some redundant code in
G1DirtyCardQueueSet::abandon_completed_buffers. After the two removed lines
it calls take_all_completed_buffers, which begins with those same two lines.

Testing:
Local (linux-x64) hotspot:tier1 with -XX:+UseG1GC.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273386: Remove duplicated code in G1DCQS::abandon_completed_buffers

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5382/head:pull/5382
$ git checkout pull/5382

Update a local copy of the PR:
$ git checkout pull/5382
$ git pull https://git.openjdk.java.net/jdk pull/5382/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5382

View PR using the GUI difftool:
$ git pr show -t 5382

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5382.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 6, 2021

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2021

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Sep 6, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 6, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm and trivial.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2021

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273386: Remove duplicated code in G1DCQS::abandon_completed_buffers

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • fc546d6: 8273378: Shenandoah: Remove the remaining uses of os::is_MP
  • 7bd4f49: 8264207: CodeStrings does not honour fixed address assumption.
  • 2cabec8: 8253343: Extract G1 Young GC algorithm related code from G1CollectedHeap

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 6, 2021
@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Sep 6, 2021

Lgtm and trivial.

Thanks for review @tschatzl . Agree this is trivial, so integrating now.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2021

Going to push as commit eb22181.
Since your change was applied there have been 3 commits pushed to the master branch:

  • fc546d6: 8273378: Shenandoah: Remove the remaining uses of os::is_MP
  • 7bd4f49: 8264207: CodeStrings does not honour fixed address assumption.
  • 2cabec8: 8253343: Extract G1 Young GC algorithm related code from G1CollectedHeap

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2021

@kimbarrett Pushed as commit eb22181.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the cleanup_acb branch Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
2 participants