8273416: C2: assert(false) failed: bad AD file after JDK-8252372 with UseSSE={0,1}

[shipilev]

See the bug report for reproducer and failure message. I think the newly added CastDD/CastFF nodes should handle the extended regDPR/regFPR (which includes FPU "registers") instead of just regD/regF to avoid this mismatch error when UseSSE < 2.

Unfortunately, we cannot just use reg*PR operands in existing match rules, because those operands are defined as UseSSE < 2, and using them as operands and ideal_regs() would break the matching on UseSSE >= 2. Therefore I had to add another pair of matches.

Additonal testing:

• Linux x86_32 tier1 -XX:UseAVX=0 -XX:UseSSE=0
• Linux x86_32 tier1 default
• Linux x86_64 tier1 default

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8273416: C2: assert(false) failed: bad AD file after JDK-8252372 with UseSSE={0,1}

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Roland Westrelin (@rwestrel - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5386/head:pull/5386
$ git checkout pull/5386

Update a local copy of the PR:
$ git checkout pull/5386
$ git pull https://git.openjdk.java.net/jdk pull/5386/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5386

View PR using the GUI difftool:
$ git pr show -t 5386

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5386.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[bridgekeeper]

@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mlbridge]

Webrevs

• 00: Full (a49e4b36)

[vnkozlov]

Good.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273416: C2: assert(false) failed: bad AD file after JDK-8252372 with UseSSE={0,1}

Reviewed-by: kvn, roland

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 67 new commits pushed to the master branch:

• 24cf480: 8276047: G1: refactor G1CardSetArrayLocker
• e922023: 8275909: [JVMCI] c2v_readFieldValue use long instead of jlong for the offset parameter
• 157e1d5: 8275856: Remove MetaspaceHandleDeallocations debug switch
• c9e65f8: 8275440: Remove VirtualSpaceList::is_full()
• de93b1d: 8257722: Improve "keytool -printcert -jarfile" output
• 21da218: 8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior
• 48f3fca: 8275308: Add valueOf(Runtime.Version) factory to SourceVersion
• c6339cb: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle
• 5a768f7: 8276054: JMH benchmarks for Fences
• 6d8fa8f: 8255286: Implement ParametersTypeData::print_data_on fully
• ... and 57 more: https://git.openjdk.java.net/jdk/compare/f6232982b91cb2314e96ddbde3984836a810a556...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Thanks @vnkozlov. @rwestrel, you good with this?

[rwestrel]

Looks good to me.

[shipilev]

Thank you!

/integrate

[openjdk]

Going to push as commit 89ade1d.
Since your change was applied there have been 86 commits pushed to the master branch:

• dbf5100: 8276201: Shenandoah: Race results degenerated GC to enter wrong entry point
• 5bb1992: 8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains
• 158831e: 8274320: os::fork_and_exec() should be using posix_spawn
• bf2e9ee: 8275080: G1CollectedHeap::expand() returns the wrong value
• b7104ba: 8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails
• 6875678: 8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned
• 5bbc8d3: 8274621: NullPointerException because listenAddress[0] is null
• 5021a12: 8274855: vectorapi tests failing with assert(!vbox->is_Phi()) failed
• fe6a202: 8271356: Modify jdb to treat an empty command as a repeat of the previous command
• cef9db9: 8276039: Remove unnecessary qualifications of java_lang_Class::
• ... and 76 more: https://git.openjdk.java.net/jdk/compare/f6232982b91cb2314e96ddbde3984836a810a556...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 89ade1d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.