Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8273351 bad tag in jdk.random module-info.java #5388

Closed
wants to merge 1 commit into from

Conversation

@JimLaskey
Copy link
Member

@JimLaskey JimLaskey commented Sep 7, 2021

Wrong tag used to identify used modules. The 's' is missing from the @use tag. Also noted is that an internal module is specified. This PR corrects spelling of tag and removes internal module reference.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5388/head:pull/5388
$ git checkout pull/5388

Update a local copy of the PR:
$ git checkout pull/5388
$ git pull https://git.openjdk.java.net/jdk pull/5388/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5388

View PR using the GUI difftool:
$ git pr show -t 5388

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5388.diff

@JimLaskey
Copy link
Member Author

@JimLaskey JimLaskey commented Sep 7, 2021

/csr

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 7, 2021

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

@JimLaskey this pull request will not be integrated until the CSR request JDK-8273431 for issue JDK-8273351 has been approved.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

@JimLaskey To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

Loading

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Sep 7, 2021

I don't think this this needs a CSR.

Loading

@openjdk openjdk bot removed the csr label Sep 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273351: bad tag in jdk.random module-info.java

Reviewed-by: rriggs, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 128 new commits pushed to the master branch:

  • ec9d1be: 8273194: Document the two possible cases when Lookup::ensureInitialized returns
  • 81d2ace: 8273369: Computing micros between two instants unexpectedly overflows for some cases
  • efe3ed1: 8273358: macOS Monterey does not have the font Times needed by Serif
  • e58c12e: 8273512: Fix the copyright header of x86 macroAssembler files
  • 461a467: 8273456: Do not hold ttyLock around stack walking
  • 695b434: Merge
  • 4afbcaf: 8273592: Backout JDK-8271868
  • a37254c: 8271868: Warn user when using mac-sign option with unsigned app-image.
  • c464f09: 8273402: Use derived NamingExceptions in com.sun.jndi.ldap.Connection#readReply
  • 4e6de5f: 8273541: Cleaner Thread creates with normal priority instead of MAX_PRIORITY - 2
  • ... and 118 more: https://git.openjdk.java.net/jdk/compare/683e30db79789ee44b3cc0b44c085de4615bca7b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 10, 2021
bplb
bplb approved these changes Sep 10, 2021
@JimLaskey
Copy link
Member Author

@JimLaskey JimLaskey commented Sep 10, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

Going to push as commit d4177a9.
Since your change was applied there have been 128 commits pushed to the master branch:

  • ec9d1be: 8273194: Document the two possible cases when Lookup::ensureInitialized returns
  • 81d2ace: 8273369: Computing micros between two instants unexpectedly overflows for some cases
  • efe3ed1: 8273358: macOS Monterey does not have the font Times needed by Serif
  • e58c12e: 8273512: Fix the copyright header of x86 macroAssembler files
  • 461a467: 8273456: Do not hold ttyLock around stack walking
  • 695b434: Merge
  • 4afbcaf: 8273592: Backout JDK-8271868
  • a37254c: 8271868: Warn user when using mac-sign option with unsigned app-image.
  • c464f09: 8273402: Use derived NamingExceptions in com.sun.jndi.ldap.Connection#readReply
  • 4e6de5f: 8273541: Cleaner Thread creates with normal priority instead of MAX_PRIORITY - 2
  • ... and 118 more: https://git.openjdk.java.net/jdk/compare/683e30db79789ee44b3cc0b44c085de4615bca7b...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

@JimLaskey Pushed as commit d4177a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants