-
Notifications
You must be signed in to change notification settings - Fork 5.8k
JDK-8273351 bad tag in jdk.random module-info.java #5388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/csr |
👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into |
@JimLaskey this pull request will not be integrated until the CSR request JDK-8273431 for issue JDK-8273351 has been approved. |
@JimLaskey To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
I don't think this this needs a CSR. |
@JimLaskey This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 128 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit d4177a9.
Your commit was automatically rebased without conflicts. |
@JimLaskey Pushed as commit d4177a9. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Wrong tag used to identify used modules. The 's' is missing from the @use tag. Also noted is that an internal module is specified. This PR corrects spelling of tag and removes internal module reference.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5388/head:pull/5388
$ git checkout pull/5388
Update a local copy of the PR:
$ git checkout pull/5388
$ git pull https://git.openjdk.java.net/jdk pull/5388/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5388
View PR using the GUI difftool:
$ git pr show -t 5388
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5388.diff