Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254144: Non-x86 Zero builds fail with return-type warning in os_linux_zero.cpp #539

Closed

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Oct 7, 2020

Pretty trivial: missing return statement for non-void returning function. GCC complains about it in 11u, but not in HEAD. Still, I believe we should fix it everywhere.

Testing:

  • Linux Zero arm32 build, HEAD
  • Linux Zero arm32 build, 11u

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8254144: Non-x86 Zero builds fail with return-type warning in os_linux_zero.cpp

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/539/head:pull/539
$ git checkout pull/539

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 7, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2020

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@shipilev shipilev changed the title 8254144: Non-x86 Zero builds fail with return-type warning in os_linux.cpp 8254144: Non-x86 Zero builds fail with return-type warning in os_linux_zero.cpp Oct 7, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 7, 2020

Webrevs

Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

Looks good and trivial

@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2020

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254144: Non-x86 Zero builds fail with return-type warning in os_linux_zero.cpp

Reviewed-by: zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 7, 2020
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Oct 8, 2020

/integrate

@openjdk openjdk bot closed this Oct 8, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 8, 2020

@shipilev Since your change was applied there have been 2 commits pushed to the master branch:

  • 7952c06: 8254166: Zero: return-type warning in zeroInterpreter_zero.cpp
  • 894ec76: 8254027: gc/g1/TestHumongousConcurrentStartUndo.java failed with "'Concurrent Mark Cycle' missing from stdout/stderr"

Your commit was automatically rebased without conflicts.

Pushed as commit 8f9e479.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the shipilev:JDK-8254144-zero-non-x86-return branch Oct 8, 2020
@gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Oct 17, 2020

This is JDK-8199973.

https://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/ce3abb5889fb

Your patch misses the same case in *BSD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants