Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273439: Fix G1CollectedHeap includes and forward declarations #5393

Conversation

@tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Sep 7, 2021

Hi all,

can I have reviews for this change that

  • removes unnecessary includes (just one actually)
  • removes unnecessary forwards (either not used, or already covered by the #include declaration)
  • sorts the forward declarations
  • adds necessary forwards that were not directly included

Testing: building on various platforms

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273439: Fix G1CollectedHeap includes and forward declarations

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5393/head:pull/5393
$ git checkout pull/5393

Update a local copy of the PR:
$ git checkout pull/5393
$ git pull https://git.openjdk.java.net/jdk pull/5393/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5393

View PR using the GUI difftool:
$ git pr show -t 5393

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5393.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 7, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label Sep 7, 2021
@tschatzl tschatzl marked this pull request as ready for review Sep 7, 2021
@openjdk openjdk bot added the rfr label Sep 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 7, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273439: Fix G1CollectedHeap includes and forward declarations

Reviewed-by: ayang, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • 7fd6b0b: 8273242: (test) Refactor to use TestNG for RuntimeTests ExecCommand tests
  • a5e4def: 8265489: Stress test times out because of long ObjectSynchronizer::monitors_iterate(...) operation
  • 9b5991e: 8273451: Remove unreachable return in mutexLocker::wait
  • e680503: 8273185: Rename the term "atomic" in ReferenceProcessor
  • ba31eee: 8273109: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest times out
  • 4d5e1ed: 8272375: Improve phrasing of synthesized descriptions in JavaFX docs
  • 267c61a: 8273361: InfoOptsTest is failing in tier1
  • f7e9f56: 8273359: CI: ciInstanceKlass::get_canonical_holder() doesn't respect instance size
  • d7efd0e: 8273450: Fix the copyright header of SVML files
  • e5f298a: 8273329: Remove redundant null check from String.getBytes(String charsetName)
  • ... and 22 more: https://git.openjdk.java.net/jdk/compare/377b186724473475480b834d99c38b8161bf6917...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 7, 2021
Copy link

@kimbarrett kimbarrett left a comment

Looks good.

Loading

@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Sep 9, 2021

Thanks @kimbarrett @albertnetymk for your reviews.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

Going to push as commit 5b1dfe4.
Since your change was applied there have been 35 commits pushed to the master branch:

  • 6eba443: 8273387: remove some unreferenced gtk-related functions
  • 5df2648: 8273218: G1: Rename g1EvacuationInfo to g1EvacInfo
  • 12f0b77: 8273516: ProblemList compiler/c2/Test7179138_1.java in -Xcomp mode on win-X64
  • 7fd6b0b: 8273242: (test) Refactor to use TestNG for RuntimeTests ExecCommand tests
  • a5e4def: 8265489: Stress test times out because of long ObjectSynchronizer::monitors_iterate(...) operation
  • 9b5991e: 8273451: Remove unreachable return in mutexLocker::wait
  • e680503: 8273185: Rename the term "atomic" in ReferenceProcessor
  • ba31eee: 8273109: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest times out
  • 4d5e1ed: 8272375: Improve phrasing of synthesized descriptions in JavaFX docs
  • 267c61a: 8273361: InfoOptsTest is failing in tier1
  • ... and 25 more: https://git.openjdk.java.net/jdk/compare/377b186724473475480b834d99c38b8161bf6917...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

@tschatzl Pushed as commit 5b1dfe4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@tschatzl tschatzl deleted the submit/8273439-g1collectedheap-forwards branch Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants