Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273185: Rename the term "atomic" in ReferenceProcessor #5397

Closed

Conversation

@tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Sep 7, 2021

Hi all,

please review this suggestion to rename the term "atomic" in the ReferenceProcessor class to "concurrent"/"stw" to avoid the confusion with Atomic operations.

It's a smaller change than expected, which is good, but also might question the need for this change. I grepped for "atomic" in the reference processor sources and hopefully got everything.

Testing: tier1-5

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273185: Rename the term "atomic" in ReferenceProcessor

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5397/head:pull/5397
$ git checkout pull/5397

Update a local copy of the PR:
$ git checkout pull/5397
$ git pull https://git.openjdk.java.net/jdk pull/5397/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5397

View PR using the GUI difftool:
$ git pr show -t 5397

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5397.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 7, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label Sep 7, 2021
@tschatzl tschatzl marked this pull request as ready for review Sep 8, 2021
@openjdk openjdk bot added the rfr label Sep 8, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 8, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273185: Rename the term "atomic" in ReferenceProcessor

Reviewed-by: ayang, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • a66629a: 8254167: G1: Record regions where evacuation failed to provide targeted iteration
  • 286a1f6: 8273440: Zero: Disable runtime/Unsafe/InternalErrorTest.java
  • 7d24a33: 8273318: Some containers/docker/TestJFREvents.java configs are running out of memory
  • 1513dc7: 8271603: Unnecessary Vector usage in java.desktop
  • ea4907a: 8273047: test jfr/api/consumer/TestRecordedFrame.java timing out
  • 4eacdb3: 8273104: Refactoring option parser for UL
  • 8884d2f: 8273462: ProblemList vmTestbase/vm/mlvm/anonloader/stress/oome/heap/Test.java in -Xcomp mode
  • d6d6c06: 8273246: Amend the test java/nio/channels/DatagramChannel/ManySourcesAndTargets.java to execute in othervm mode
  • 708407e: 8273168: Remove superfluous use of boxing in java.desktop
  • 270a9d9: 8273043: [TEST_BUG] Automate NimbusJTreeSelTextColor.java
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/377b186724473475480b834d99c38b8161bf6917...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 8, 2021
Copy link
Contributor

@shipilev shipilev left a comment

This looks fine to me, with one nit.

Loading

src/hotspot/share/gc/shared/referenceProcessor.cpp Outdated Show resolved Hide resolved
Loading
@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Sep 8, 2021

I looked through the GHA failures, none of that related to this change.

Thanks @shipilev @albertnetymk for your reviews.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

Going to push as commit e680503.
Since your change was applied there have been 28 commits pushed to the master branch:

  • ba31eee: 8273109: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest times out
  • 4d5e1ed: 8272375: Improve phrasing of synthesized descriptions in JavaFX docs
  • 267c61a: 8273361: InfoOptsTest is failing in tier1
  • f7e9f56: 8273359: CI: ciInstanceKlass::get_canonical_holder() doesn't respect instance size
  • d7efd0e: 8273450: Fix the copyright header of SVML files
  • e5f298a: 8273329: Remove redundant null check from String.getBytes(String charsetName)
  • cb112af: 8269373: some tests in jdk/tools/launcher/ fails on localized Windows platform
  • 7e662e7: 8272413: Incorrect num of element count calculation for vector cast
  • f2f8136: 8265443: IGV: disambiguate groups by emiting additional properties
  • 59c9f75: 8273375: Remove redundant 'new String' calls after concatenation in java.desktop
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/377b186724473475480b834d99c38b8161bf6917...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

@tschatzl Pushed as commit e680503.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@tschatzl tschatzl deleted the submit/8273185-rename-atomic branch Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants