Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273451: Remove unreachable return in mutexLocker::wait #5398

Closed
wants to merge 1 commit into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Sep 7, 2021

Refactored mutexLocker::wait to return redundant unreachable "return false;"


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273451: Remove unreachable return in mutexLocker::wait

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5398/head:pull/5398
$ git checkout pull/5398

Update a local copy of the PR:
$ git checkout pull/5398
$ git pull https://git.openjdk.java.net/jdk pull/5398/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5398

View PR using the GUI difftool:
$ git pr show -t 5398

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5398.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 7, 2021

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

@lmesnik The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Sep 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 7, 2021

Webrevs

yminqi
yminqi approved these changes Sep 7, 2021
Copy link
Contributor

@yminqi yminqi left a comment

LGTM.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273451: Remove unreachable return in mutexLocker::wait

Reviewed-by: minqi, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 708407e: 8273168: Remove superfluous use of boxing in java.desktop

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 7, 2021
coleenp
coleenp approved these changes Sep 7, 2021
Copy link
Contributor

@coleenp coleenp left a comment

This looks good!

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Sep 8, 2021

I think the change to the ?: operator was unnecessary and does not improve readability. YMMV.

@lmesnik
Copy link
Member Author

@lmesnik lmesnik commented Sep 8, 2021

I don't see a big difference here but prefer ?: in such cases. Just a little more compact.

@lmesnik
Copy link
Member Author

@lmesnik lmesnik commented Sep 8, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

Going to push as commit 9b5991e.
Since your change was applied there have been 24 commits pushed to the master branch:

  • e680503: 8273185: Rename the term "atomic" in ReferenceProcessor
  • ba31eee: 8273109: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest times out
  • 4d5e1ed: 8272375: Improve phrasing of synthesized descriptions in JavaFX docs
  • 267c61a: 8273361: InfoOptsTest is failing in tier1
  • f7e9f56: 8273359: CI: ciInstanceKlass::get_canonical_holder() doesn't respect instance size
  • d7efd0e: 8273450: Fix the copyright header of SVML files
  • e5f298a: 8273329: Remove redundant null check from String.getBytes(String charsetName)
  • cb112af: 8269373: some tests in jdk/tools/launcher/ fails on localized Windows platform
  • 7e662e7: 8272413: Incorrect num of element count calculation for vector cast
  • f2f8136: 8265443: IGV: disambiguate groups by emiting additional properties
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/270a9d929307dce52e6961e57492c03a633ed044...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

@lmesnik Pushed as commit 9b5991e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lmesnik lmesnik deleted the 8273451 branch Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
4 participants