Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273450: Fix the copyright header of SVML files #5399

Closed
wants to merge 1 commit into from

Conversation

sviswa7
Copy link

@sviswa7 sviswa7 commented Sep 7, 2021

Fix the copyright header of SVML files to match others.

This was brought up on jdk-dev mailing list:
https://mail.openjdk.java.net/pipermail/jdk-dev/2021-September/005992.html


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5399/head:pull/5399
$ git checkout pull/5399

Update a local copy of the PR:
$ git checkout pull/5399
$ git pull https://git.openjdk.java.net/jdk pull/5399/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5399

View PR using the GUI difftool:
$ git pr show -t 5399

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5399.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 7, 2021

👋 Welcome back sviswanathan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8273450: Fix the copyright header of SVML file 8273450: Fix the copyright header of SVML files Sep 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

@sviswa7 To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@sviswa7
Copy link
Author

@sviswa7 sviswa7 commented Sep 7, 2021

/label core-libs

@openjdk openjdk bot added the core-libs label Sep 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

@sviswa7
The core-libs label was successfully added.

@sviswa7 sviswa7 marked this pull request as ready for review Sep 7, 2021
@openjdk openjdk bot added the rfr label Sep 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 7, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Sandhya,

You must not change another company's copyright line, so "All rights reserved" needs to be removed again.

Thanks,
David

@sviswa7
Copy link
Author

@sviswa7 sviswa7 commented Sep 7, 2021

@dholmes-ora I am from Intel so editing the Intel copyright line should be ok?

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Sep 7, 2021

@sviswa7 My apologies, I hadn't realized you worked for Intel. But note that other Intel files i.e. ./hotspot/cpu/x86/macroAssembler_x86_*.cpp also do not have "All rights reserved".

David

@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

@sviswa7 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273450: Fix the copyright header of SVML files

Reviewed-by: dholmes, psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 4eacdb3: 8273104: Refactoring option parser for UL
  • 8884d2f: 8273462: ProblemList vmTestbase/vm/mlvm/anonloader/stress/oome/heap/Test.java in -Xcomp mode
  • d6d6c06: 8273246: Amend the test java/nio/channels/DatagramChannel/ManySourcesAndTargets.java to execute in othervm mode
  • 708407e: 8273168: Remove superfluous use of boxing in java.desktop
  • 270a9d9: 8273043: [TEST_BUG] Automate NimbusJTreeSelTextColor.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 7, 2021
@sviswa7
Copy link
Author

@sviswa7 sviswa7 commented Sep 8, 2021

Thanks a lot @dholmes-ora for the review.

@sviswa7
Copy link
Author

@sviswa7 sviswa7 commented Sep 8, 2021

Thanks a lot @PaulSandoz for the review.

@sviswa7
Copy link
Author

@sviswa7 sviswa7 commented Sep 8, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

Going to push as commit d7efd0e.
Since your change was applied there have been 19 commits pushed to the master branch:

  • e5f298a: 8273329: Remove redundant null check from String.getBytes(String charsetName)
  • cb112af: 8269373: some tests in jdk/tools/launcher/ fails on localized Windows platform
  • 7e662e7: 8272413: Incorrect num of element count calculation for vector cast
  • f2f8136: 8265443: IGV: disambiguate groups by emiting additional properties
  • 59c9f75: 8273375: Remove redundant 'new String' calls after concatenation in java.desktop
  • faa942c: 8273000: Remove WeakReference-based class initialisation barrier implementation
  • 21012f2: 8078641: MethodHandle.asTypeCache can retain classes from unloading
  • 1855574: 8273038: ChannelInputStream.transferTo() uses FileChannel.transferTo(FileChannel)
  • 6750c34: 8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS
  • a66629a: 8254167: G1: Record regions where evacuation failed to provide targeted iteration
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/df05b4d1a13e55755107695ad9ea7a8a1084901a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

@sviswa7 Pushed as commit d7efd0e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sviswa7 sviswa7 deleted the svmlheader branch Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
3 participants