Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273478: [macos11] JTabbedPane selected and pressed tab is not legible #5409

Closed
wants to merge 1 commit into from

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Sep 8, 2021

On macOS 11 (bigsur), using the Swing Aqua Look and Feel,
the text of the selected and "pressed" JTabbedPane tab title text is just a light gray outline of white text on a white background which is not readable.
Fix is to use selectedControlTextColor for TabbedPane.selectedTabTitlePressedColor same as what we use for TabbedPane.selectedTabTitleNormalColor. Result is black over white text same as what is seen for native app pressed tabbedpane.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273478: [macos11] JTabbedPane selected and pressed tab is not legible

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5409/head:pull/5409
$ git checkout pull/5409

Update a local copy of the PR:
$ git checkout pull/5409
$ git pull https://git.openjdk.java.net/jdk pull/5409/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5409

View PR using the GUI difftool:
$ git pr show -t 5409

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5409.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 8, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

@prsadhuk The following labels will be automatically applied to this pull request:

  • 2d
  • awt
  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Sep 8, 2021

/label remove 2d, awt

Loading

@openjdk openjdk bot removed 2d awt labels Sep 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

@prsadhuk
The 2d label was successfully removed.

The awt label was successfully removed.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 8, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273478: [macos11] JTabbedPane selected and pressed tab is not legible

Reviewed-by: kizune, aivanov, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 261 new commits pushed to the master branch:

  • 08f0be8: 8272608: java_lang_System::allow_security_manager() doesn't set its initialization flag
  • 2e321dc: 8273528: Avoid ByteArrayOutputStream.toByteArray when converting stream to String
  • 54dee13: 8273188: java/lang/instrument/BootClassPath/BootClassPathTest.sh fails with "FATAL ERROR in native method: processing of -javaagent failed, processJavaStart failed"
  • 4020a60: 8273550: Replace os::cgc_thread/pgc_thread with os::gc_thread
  • 185eaca: 8273545: Remove Thread::is_GC_task_thread()
  • dd1209e: 8268885: duplicate checkcast when destination type is not first type of intersection type
  • ef4a532: 8263773: Reenable German localization for builds at Oracle
  • 96614da: 8272903: Missing license header in ArenaAllocator.java
  • e3bda63: 8273489: Zero: Handle UseHeavyMonitors on all monitorenter paths
  • c81690d: 8273498: compiler/c2/Test7179138_1.java timed out
  • ... and 251 more: https://git.openjdk.java.net/jdk/compare/36e2ddad4d2ef3ce27475af6244d0246a8315c0c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 9, 2021
mrserb
mrserb approved these changes Sep 10, 2021
@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Sep 13, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

Going to push as commit 4efcd20.
Since your change was applied there have been 285 commits pushed to the master branch:

  • a73c06d: 8273021: C2: Improve Add and Xor ideal optimizations
  • 9f86082: 8273610: LogTestFixture::restore_config() should not restore options
  • 2ee1f96: 8273484: Cleanup unnecessary null comparison before instanceof check in java.naming
  • f189dff: 8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian
  • 922e86f: 8273522: Rename test property vm.cds.archived.java.heap to vm.cds.write.archived.java.heap
  • f42b927: 8273609: Fix trivial doc typos in the compiler area
  • e4cd209: 8273611: Remove unused ProfilePrint_lock
  • f690a01: 8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT
  • 5e1df2c: 8273162: AbstractSplittableWithBrineGenerator does not create a random salt
  • d4177a9: 8273351: bad tag in jdk.random module-info.java
  • ... and 275 more: https://git.openjdk.java.net/jdk/compare/36e2ddad4d2ef3ce27475af6244d0246a8315c0c...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

@prsadhuk Pushed as commit 4efcd20.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@prsadhuk prsadhuk deleted the JDK-8273478 branch Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants